Fix variable-editor dialog closing when resizing the editor - #5487
Merged
norman-abramovitz merged 2 commits intoJun 23, 2026
Merged
Conversation
The app variable editor put a CSS resize grip on a small box hugging the Monaco editor. Dragging it to enlarge released the pointer on the backdrop, and the browser's synthesized click resolved to the overlay — which the dialog read as a backdrop click and closed. Resizes, then vanishes (cloudfoundry#5486). Two parts: - Backdrop dismissal now requires the press to have started on the backdrop too, not just the release. A drag that begins inside the dialog (resize grip, text selection) and ends on the backdrop no longer closes it. This was latent for every dialog. - The dialog itself is now movable and corner-resizable instead of the inner editor box. Opt-in `draggable`/`resizable` flags pin the panel to a fixed viewport position so the native resize grip tracks the cursor 1:1, let it be dragged by its header, and make the Monaco editor flex-fill the panel so it grows with it. Both drag and resize are clamped to the viewport so the panel — and its action buttons — can never be pushed off-screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5486
Problem
The app variable editor (Applications → Variables → Add/Edit) put a CSS resize grip on a small box hugging the Monaco editor. Dragging it to enlarge released the pointer on the backdrop, and the browser's synthesized click resolved to the overlay — which the dialog read as a backdrop click and closed. The editor "resized, then vanished."
Changes
Backdrop dismissal hardened (
tailwind-dialog.service.ts) — closing now requires the press to have started on the backdrop, not just the release. A drag that begins inside a dialog (resize grip, text selection) and ends on the backdrop no longer dismisses it. This was latent for every dialog.Dialog is now movable + corner-resizable instead of the inner editor box. Opt-in
draggable/resizableconfig flags:data-dialog-drag-handle);automaticLayoutre-fits);Verification
ng build stratos --configuration production) clean.Known minor edge
The viewport clamp is computed at open and after each move, not on browser-window resize while the dialog is open. Shrinking the OS window mid-edit could overflow until the panel is nudged — rare for a transient editor; can add a resize re-clamp if wanted.