Restore complete OSBAPI parameter-schema editing for service instances - #5495
Merged
norman-abramovitz merged 25 commits intoJun 25, 2026
Merged
Conversation
…rer; remove flat stub
The onRenderError handler defers its state changes via queueMicrotask. If the component is torn down between the emit and the microtask firing, the callback would set signals and open a snackbar on a destroyed view. Inject DestroyRef, flag destruction, and bail at the top of the deferred callback. The renderer's renderError emit is synchronous (fires from _seedAndBuild on a live component mid-CD), so it needs no such guard.
norman-abramovitz
approved these changes
Jun 25, 2026
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM maybe some cleanup on text styling but does not hold up getting the functionality back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores complete OSBAPI (JSON Schema) parameter editing on the service-instance create/update form. The Tailwind/ngrx migration had replaced the AJSF-based schema form with a flat stub that dropped nesting, arrays, and composition; this brings that capability back, signal-native, with Monaco for the raw-JSON view.
Closes #5488.
What's in it
SchemaWidgetRenderer(selectorjson-schema-form) covering the full JSON Schema Draft-4 vocabulary: object nesting, scalars (incl.formatsuch as password), enum selects, arrays (add/remove/reorder), multi-select (uniqueItemsenum arrays),oneOf/anyOf(including scalar branches),allOf,$ref/$defs, anadditionalPropertiesmap editor, tuples, and anunknown-node JSON fallback so nothing is unrenderable.5vs string"5"warns but does not block).TailwindJsonSchemaForm*) and its dead service; the Kubernetes chart-values editor moves to the new renderer.Verification
Follow-ups (separate)