Preview service plan parameters from the marketplace Plans tab - #5497
Merged
norman-abramovitz merged 3 commits intoJun 25, 2026
Merged
Conversation
The Plans tab lists plans at the summary tier, which omits the broker-advertised parameter schemas — so a user could not see what a plan would prompt for without committing to the create wizard. Add a View parameters action to each plan's row menu that lazily fetches the plan at the details tier and shows its create-instance schema as a read-only tree (or 'no configurable parameters' when none is set). Closes cloudfoundry#5493
The JSON tree's structural colors (keys, value fallback, separators, toggler) were hard-coded for the light theme — keys a fixed purple and values black — leaving them low-contrast or invisible on the dark theme. Route them through the content theme tokens so the tree is legible in both themes; the syntax-accent hues stay static. Also improves the Kubernetes resource viewer and Helm release values views, which share this component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The marketplace Plans tab lists plans at the summary tier, which omits the broker-advertised parameter schemas. A user evaluating a service therefore could not see what a plan would prompt for without committing to the create-instance wizard.
This adds a View parameters action to each plan row. It lazily fetches the selected plan at the details tier (the only tier that carries
schemas) and shows its create-instance parameter schema as a read-only tree, or "This plan has no configurable parameters" when the broker advertises none. The summary-tier list fetch is unchanged, so the list stays light — the schema is pulled only when asked, one plan at a time.While verifying in dark mode, the shared json-viewer component turned out to hard-code its tree colors for the light theme (keys a fixed purple, value fallback black), leaving them low-contrast or invisible on dark. Its structural colors now resolve through the content theme tokens, which also fixes the Kubernetes resource viewer and Helm release values views that share the component.
Verified in a running stack against an example broker (free/rich schema and paid/deeply-nested schema) and a real Blacksmith broker plan (no schema), in both light and dark themes.
Closes #5493