Adapt remaining light-only placeholder and chart colors to dark theme - #5498
Merged
norman-abramovitz merged 2 commits intoJun 25, 2026
Merged
Conversation
Two raw colors missed by the theme-token sweep did not adapt to the dark theme: the recent-apps loading placeholder bars stayed light on the dark card, and the usage chart's 'unknown' swatch was a fixed grey while its sibling state swatches already resolved via tokens. Give the placeholder a dark-theme fill alongside its existing dark border, and route the unknown swatch through the muted content token. Toward cloudfoundry#5494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the theme-token color sweep. Triaging the component SCSS files the sweep left with raw hex turned up two colors that genuinely do not adapt to the dark theme:
compact-app-card) stayed light grey on the dark card. Given a dark-theme fill, matching the dark border treatment already in that file.unknownswatch (simple-usage-chart) was a fixed grey while its sibling state swatches (ok/warning/danger) already resolve via tokens. Routed through the muted content token.The other raw-hex matches were checked and left deliberately: white text on coloured alert/step backgrounds (intentional inverse), chart gridline internals (the separate getComputedStyle convention), and the example-extensions demo package.
Build verified. These two states are transient/data-dependent (a brief loading flash; an unknown-usage segment) so they were not reproduced live; the changes are minimal and consistent with each file’s existing dark mechanism.
Closes #5494