feat(stepper): consistently offer Cancel across setup wizards - #5522
Merged
norman-abramovitz merged 1 commit intoJul 1, 2026
Merged
Conversation
The shared stepper only renders Cancel when a `cancel` route is passed, so the three first-run setup wizards (welcome, UAA, local account) showed none. Give them the generic themed Cancel button instead of leaving the flow un-cancellable. - uaa/local: [cancel]="'/setup'" routes back to the auth-method choice. - welcome is the flow's start with no in-app destination, so add an optional `cancelReload` input: the same button does a full-page window.location load to `cancel`, matching the setup flow's existing hard-reload-on-success idiom and restarting the wizard clean. cancelReload defaults off, so all existing steppers are unchanged. Toward cloudfoundry#5521.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the first-run setup wizards into line with every other Stratos stepper so a Cancel button is consistently offered.
The shared stepper only renders Cancel when a
cancelroute is supplied (!hideCloseButton && cancelinsteppers.component.html). An audit of all 36<app-steppers>consumers found 33 already pass acancelroute (they render Cancel today); the only ones missing it were the three pre-login setup wizards.Changes
console-uaa-wizard,local-account-wizard—[cancel]="'/setup'": the generic themed Cancel now returns to the welcome / auth-method choice, restarting the flow.setup-welcome— it's the flow's start with no in-app destination, so a router nav would be a no-op. Added an optionalcancelReloadinput to the shared stepper: the same Cancel button does a full-pagewindow.location.assign(cancel), matching the setup flow's existing hard-reload-on-success idiom. Opted in via[cancel]="'/setup'" [cancelReload]="true".cancelReloaddefaults off, so all existing steppers are behavior-identical (routerLink still resolves tocancel$,onCanceljust callsonLeave(false)).Verification
vitest --project=core --project=cloud-foundryover the shared stepper suite + consumers (steppers.component,steppers-destructive-flowcanClosegating,step.component,stepper-form,add-route-stepper, all three setup specs): 21 files / 65 tests pass.Out of scope (follow-up)
Modal dialogs (
connect-endpoint,add-api-key,add-user,variable-edit,rollback, …) hand-roll their own Cancel with inconsistent classes (btn-warn/btn-danger/btn-secondary). Not<app-steppers>consumers — a separate normalization worth its own issue.Closes #5521.