fix(cf): stop app-detail remount + env-var refetch on every tab (#5519)

[nabramovitz]

Closes #5519

Problem

Clicking between an application's side tabs (Summary, Log Stream, Revisions, Routes, Variables, Services, Events) triggers a fetch of /v3/apps/:guid/environment_variables every time, each emitting an audit.app.environment.show event and polluting the app's event feed. Env vars should only be fetched for the Variables tab.

Root cause

CustomReuseStrategy reuses a route only when a reuseRoute marker matches; the app-detail routes carried none, so every tab navigation tore down and rebuilt ApplicationBaseComponent. Its ngOnInit re-runs the eager data load (refresh('all')), which includes the env-vars fetch → an audit event per tab click.

A plain reuseRoute marker can't be used directly here: ApplicationBaseComponent derives its CF/app GUIDs from route params via construction-time DI factories, so reusing the instance across two different apps (A → B) would leave it pinned to app A's data.

Fix

Teach the component-keyed branch of shouldReuseRoute to also require the route node's own params to match:

• same params (tab switch) → shell is reused, no remount, no env-vars refetch;
• different params (different app) → shell rebuilds, GUIDs correct.

Then mark the app-detail shell (ApplicationBaseComponent) and tabs-base (ApplicationTabsBaseComponent) routes. Also fixes the same latent cross-resource staleness for the k8s helm-release shell, which uses the identical construction-time-guid pattern (verified). Adds route-reuse-stragegy.spec.ts covering param-aware reuse.

Verification

Strategy unit tests (4/4) cover reuse-on-same-params and rebuild-on-different-params. End-to-end live verification (clicking tabs, confirming the env-vars call no longer fires and the event feed stays clean) is pending an available CF endpoint and should be done before merge.

[norman-abramovitz]

LGTM

[norman-abramovitz]

LGTM