ci(stb): make the required STB Tests check report on all PRs - #5527
Merged
norman-abramovitz merged 1 commit intoJul 1, 2026
Merged
Conversation
STB Tests is a required status check on develop/main, but the workflow was `paths`-filtered to tools/stb + instrumented templates. GitHub never reports a required check that a PR's paths don't trigger, so every PR that doesn't touch stb (backend-only, most frontend) got stuck on "STB Tests — Expected — Waiting for status to be reported" and could not merge. Trigger the workflow on every PR to the protected branches and decide internally whether to run the gate: a dorny/paths-filter step sets an `stb` output, each real step is gated on it, and an else-branch step reports green when stb is untouched. The job always runs, so the required check is always satisfied; real stb changes still run the full typecheck/lint/test/drift gate. Self-unblocking: this PR modifies the workflow, and pull_request runs the PR's own version, so STB Tests runs (and passes) on this PR too.
norman-abramovitz
approved these changes
Jul 1, 2026
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
STB Testsis a required status check ondevelop/main, but the workflow ispaths-filtered (tools/stb/**+ a few instrumented templates). GitHub never reports a required check that a PR's paths don't trigger, so every PR that doesn't touch stb (backend-only, most frontend) gets stuck indefinitely on:…and cannot be merged. (Live example: several open bug-fix PRs are blocked on this alone, with all 12 real checks green.)
Fix
Trigger the workflow on every PR to the protected branches, and decide internally whether to run the gate:
dorny/paths-filterstep sets anstboutput from the same path list;npm install, Playwright, typecheck, lint, tests, both drift lints) is gated onsteps.changes.outputs.stb == 'true';The job always runs, so the required check is always satisfied; real stb changes still run the full gate exactly as before.
Self-unblocking
pull_requestruns the workflow as it exists in the PR's merge ref, so this PR's own modified workflow runs on it — STB Tests executes and passes here too.Note
dorny/paths-filter@v3is a third-party action (widely used across CNCF projects). If the org prefers to avoid non-GitHub actions, this can be swapped for a nativegit diff --name-onlystep — happy to change it.