fix(build): generate backend plugins before every build - #5587
Merged
norman-abramovitz merged 2 commits intoJul 6, 2026
Merged
Conversation
extra_plugins.go is generated from plugin-config.yaml and gitignored, so a fresh checkout compiled a plugin-less jetstream: no cloudfoundry plugin, 'Unknown endpoint type "cf"' warnings, and a silently empty endpoints page. Only the korifi target and cross-compile.sh ran the generator. Consolidate the step as an internal gen-plugins prerequisite shared by 'build backend' and 'build korifi' (dev backend inherits it), and guard cross-compile.sh against running outside the repo root.
macOS's bundled GNU Make 3.81 prints 'No rule to make target site.mk. Stop.' for a missing -include'd file (then continues anyway); newer make is silent. Wrap the include in $(wildcard) so 3.81 never attempts the file when absent. Behavior with a site.mk present is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two build-system fixes:
Plugin generation runs before every backend build.
extra_plugins.gois generated fromplugin-config.yamland gitignored, so a fresh checkout compiled a plugin-less jetstream: no cloudfoundry plugin,Unknown endpoint type "cf"warnings in the log, and a silently empty endpoints page in the UI (the cf group never reaches/pp/v1/info, while/api/v1/endpointsstill returns DB rows). Only the korifi target andcross-compile.shran the generator. The step is now an internalgen-pluginsprerequisite shared bybuild backendandbuild korifi(dev backendinherits it via its delegated build), andcross-compile.shgains a repo-root guard since its paths are root-relative.Silence spurious
site.mkinclude noise on make 3.81. macOS's bundled GNU Make 3.81 printsNo rule to make target 'site.mk'. Stop.for a missing-include'd file and then continues anyway; newer make is silent. Wrapping the include in$(wildcard)keeps 3.81 quiet with no behavior change when asite.mkis present.Verification
make -n build backend PLATFORM=…,make -n build korifi, and the cross-compile branch all show generation running firstextra_plugins.go, ranmake build backend PLATFORM=darwin/arm64— file regenerated, resulting binary contains the cloudfoundry pluginsite.mkA/B: message gone when absent, include still honored when presentmake helpunchanged (gen-plugins is an internal hidden target)