feat: show starred endpoints on Home regardless of state - #5601
Merged
norman-abramovitz merged 1 commit intoJul 8, 2026
Merged
Conversation
The Home page card list was double-filtered to connected endpoints, so a starred endpoint that went down disappeared instead of reading as "down". The mode is now a header segmented control — Favorites | Connected | All — replacing the checkbox row that fused a content filter into the layout menu and hid the active mode: - Favorites: every starred endpoint (directly, or via starred child entities) regardless of connection state. - Connected: every connected endpoint, favorites sorted first. - All: every registered endpoint, any state, favorites first. The persisted boolean pref migrates to the new three-way mode. A shown endpoint that is disconnected renders a Disconnected panel with a Connect button (the endpoints-page connect dialog) and never loads its home card — no half-loaded or error card. Connecting while the card is on screen swaps the real card back in. An endpoint whose stored token has expired presents as Disconnected only when jetstream cannot mint a fresh session: /pp/v1/info now carries token_expiry and token_renewable (refresh token present) per connected endpoint. Refresh-capable endpoints renew transparently on use, so their access-token expiry stays harmless — expiry-as- disconnected matters for korifi-style pasted tokens (cloudfoundry#5489), which have no refresh and always end in expiry. Cards sort favorites group, then endpoint type (renderPriority), then natural name (cf1 < cf2 < cf10). An icon attached to the segmented control flips the name order (tooltip explains the sort); direction never reorders groups or types and persists with the other Home preferences. A divider separates the endpoint controls from the layout menu, which is back to column presets only. Home cards gain a per-endpoint layout choice (homeCard.linksBelow): kubernetes uses a Favorites/Shortcuts strip below its counts (which now sit in a horizontal tile row, with shortcuts registered at the definition level like CF); CF keeps the classic right sidebar. The kube card's conditional Open Terminal / View Dashboard shortcuts needed async checks the definition hook cannot express and remain reachable from the kubernetes pages. Shortcut links wrap inside their column instead of overflowing the card edge. Closes cloudfoundry#5588
norman-abramovitz
approved these changes
Jul 8, 2026
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM - Did Live review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Home previously double-filtered its cards to connected endpoints, so a starred endpoint that went down silently disappeared — absence read as "not favorited" rather than "down". Home can now answer both questions the issue names: "show me my connected endpoints" and "show me my starred endpoints, up or not".
Changes
Which-endpoints control
homeViewShowFavoritesOnly) keeps its meaning.Disconnected presentation
/pp/v1/infonow exposestoken_expiryandtoken_renewable(refresh token present) per connected endpoint. Refresh-capable endpoints (UAA/SSO) renew transparently on use, so their hourly access-token expiry stays harmless — the rule exists for korifi-style pasted tokens (Support Korifi (Cloud Foundry on Kubernetes) as a CF endpoint #5489), which have no refresh and always end in expiry. (The issue text said expired → Disconnected flatly; that would have flapped every idle CF endpoint, hence the renewable gate.)Sorting
renderPriority) → natural name (cf1 < cf2 < cf10; previously payload map order).Card layouts
homeCard.linksBelow): kubernetes renders its counts as a horizontal tile row with a Favorites/Shortcuts strip below; CF keeps the classic right-hand sidebar. Kube shortcuts moved to the definition level (like CF); the old in-card conditional shortcuts (Open Terminal / View Dashboard) needed async checks the sync definition hook can't express and remain reachable from the kubernetes pages.ngAfterViewInit+ input rebind both creating the card while its lazy chunk import was in flight) — regression spec included.Testing
Closes #5588