Reconnect snackbar action opens the connect dialog - #5631
Merged
norman-abramovitz merged 2 commits intoJul 12, 2026
Merged
Conversation
The auth-expired banner's Reconnect button only routed to /endpoints, leaving the user to find the endpoint row and click Connect themselves. Open the connect dialog for the affected endpoint in place instead — the endpoint config the dialog needs is already in the interceptor's hands. Falls back to /endpoints when the endpoint is unknown to the frontend. Exports ConnectEndpointDialogComponent and ConnectEndpointConfig from the core public API; the dialog was previously only reachable inside the core package. Closes cloudfoundry#5621
EndpointModel.guid is optional; ConnectEndpointConfig.guid is not. Use the interceptor's cnsiGuid lookup key — same value, correct type. Caught by the strict AOT build (vitest's transform doesn't run it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auth-expired banner's Reconnect button only routed to
/endpoints, leaving the user to find the endpoint in the list and click Connect themselves. The action was labelled for a one-click reconnect but didn't perform one.This makes the action open the connect dialog for the affected endpoint in place. The interceptor already has everything the dialog needs (
EndpointsSignalServicelookup maps 1:1 toConnectEndpointConfig), so the change is confined to theauth_expiredbranch. If the endpoint is unknown to the frontend at click time, it falls back to the old/endpointsnavigation.On the issue's open design question (in-place modal vs routing to
/endpointsfirst): went with in-place. The snackbar only appears in response to a request the current page made, and the user explicitly clicked Reconnect on it — a modal there is the expected response, and it preserves the page the user was on so a retry lands back in context.One correction to the issue text:
ConnectEndpointDialogComponentwas not actually exported from@stratosui/core— this adds that export (plusConnectEndpointConfig) to the core public API.Tests: two new interceptor specs — the Reconnect action opens the dialog with the endpoint's config, and the unknown-endpoint fallback navigates to
/endpoints. 14/14 pass.Closes #5621