chore: neutral simplification markers and #5707 review follow-ups - #5711
chore: neutral simplification markers and #5707 review follow-ups#5711nabramovitz wants to merge 1 commit into
Conversation
Six comments flagged intentional shortcuts or do-not-refactor notes behind an ad-hoc prefix rather than the marker already used elsewhere in the tree. The notes themselves are worth keeping — the snackbar one guards against a theming sweep flipping an inverse overlay to a light-on-light surface — so rename the prefix rather than drop the comments. Four become `simplification:`, matching the marker already in scripts/lint-e2e-data-test.mjs. Two become `NOTE:`, since they are not simplifications at all: the recursion guard for self-referential $ref schemas, and the snackbar inverse-overlay warning. Comment text only; no behaviour change.
|
Caution Superseded — do not merge, reuse, or branch from this PR. The branch behind this PR is stale and carries only half of the intended change. It has been replaced by #5712. Closing in favour of #5712. The single commit here ( Rather than rewrite already-pushed history, the work was redone on a branch cut from current develop. The replacement was verified to match, line for line, what this branch would have become. The branch |
Two unrelated tidy-ups, both comment- and type-level only, no behaviour change.
1. Neutral markers for deliberate simplifications
Six comments flagged deliberate shortcuts or do-not-refactor notes behind an ad-hoc prefix instead of the marker already used elsewhere in the tree. This renames the prefix; the notes themselves are unchanged in substance and worth keeping — one of them is load-bearing.
plan-parameters-preview.util.ts:19simplification:$schema, names the upgrade pathschema-resolve.util.ts:168simplification:tailwind-dialog.service.ts:412simplification:cdkDrag, with the reasontools/stb/src/main.ts:132simplification:schema-resolve.util.ts:99NOTE:tailwind-snackbar.service.ts:207NOTE:simplification:is not a new convention —scripts/lint-e2e-data-test.mjs:68already uses it. The two that becameNOTE:were never simplifications: one is a correctness guard against infinite recursion on self-referential$refschemas, the other warns that the snackbar'sbg-gray-800/text-whiteare a deliberate inverse overlay kept raw so a theming sweep doesn't convert them tocontent-*tokens and produce light-on-light text.2. Follow-ups from the #5707 review
Three loose ends raised in review on #5707 that merged before they were picked up.
onNextcoalesced the endpoint guid at thesaveAppDetailscall with?? ''.SourceType.endpointGuidis optional, so that operator was carrying the type rather than ever changing a value — the public branch is already guarded non-empty above it and the other branch is a literal''. Narrowed at the declaration instead and dropped from the object literal.The two
setGitModespecs asserted withtoHaveBeenCalledWith, which matches any call, while their comment described the last one. Switched totoHaveBeenLastCalledWithso the assertion states what the comment claims — a strictly stronger check, still green.The deferral comment in
setActivesaid a synchronouspOnEnterwould run "before the entering step is marked active". The step is marked active a few lines above it. The real constraint is that change detection has not yet re-rendered the content outlet for the newcurrentIndex, so the callback would run against a view still showing the outgoing step. Reworded to say that.Related: #5710 covers the missing test coverage that let the earlier version of that comment go unchallenged.
make check gategreen.