chore(cloud-foundry): remove dead ngrx action classes with CF v2 API paths - #5734
Merged
norman-abramovitz merged 1 commit intoAug 1, 2026
Conversation
…paths The ngrx runtime is gone since the signals refactor; these ~50 ICFAction/PaginatedAction classes carried raw CF v2 API paths and were referenced only from entity catalog builder maps that are never invoked. - delete 8 all-dead action files; trim 6 mixed files to their live classes - clean every builder-map entry referencing a removed class; emptied builder interfaces become type aliases of OrchestratedActionBuilders - remove the caller-less createGetApplicationAction factory and its orphaned imports from application.service.ts - move IUserProvidedServiceInstanceData(+Credentials) to cf-api-svc.types.ts beside IUserProvidedServiceInstance - drop dead public_api exports; resolve all three FLAG (A6) markers Closes cloudfoundry#5726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ngrx runtime was removed in the signals refactor; the ~50
ICFAction/PaginatedActionclasses inventoried in #5726 carried raw CF v2 API paths and were referenced only from entity catalog builder maps that are never invoked. This deletes them.What changed
app-metadata,app-event,application-service-routes,service-bindings,service,service-plan,service-plan-visibility,user-provided-serviceapplication,organization,space,users,service-instances,quota-definitionscf-entity-generator.tsconsumes them) astype X = OrchestratedActionBuildersaliases + empty literalscreateGetApplicationActioninapplication.service.tsremoved — a zero-caller factory wrapping the deadGetApplication(found during verification, not in the issue's inventory)IUserProvidedServiceInstanceData(+Credentials) relocated tocf-api-svc.types.tsbesideIUserProvidedServiceInstance; both importers updatedpublic_api.tsexports dropped (RemoveCfUserRole,UpdateExistingApplication)FLAG (A6)markers resolved (the issue listed two; a third sat onUpdateSpace)Verification
CreateServiceFormMode.CreateServiceInstanceenum member)make check gategreen; lint warnings in the package went down (the empty-interface pattern fix cleared pre-existing instances too)Net: +42 / −2,346 across 36 files.
Closes #5726