Fix potential ClassCastException during shadow user create#3893
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens external authentication so that a ClassCastException when evaluating the “add shadow user on login” policy no longer crashes authentication, and instead fails closed with the existing “pre-created account required” behavior.
Changes:
- Wraps shadow-user auto-creation policy evaluation to catch
ClassCastExceptionand disable auto-creation in that case. - Adds a regression test ensuring
ClassCastExceptionduring policy evaluation results inAccountNotPreCreatedExceptionand no events are published.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
server/src/main/java/org/cloudfoundry/identity/uaa/authentication/manager/ExternalLoginAuthenticationManager.java |
Adds canAddNewShadowUser() wrapper to handle ClassCastException and log a warning while failing closed. |
server/src/test/java/org/cloudfoundry/identity/uaa/authentication/manager/ExternalLoginAuthenticationManagerTest.java |
Adds a test covering the ClassCastException path during shadow user creation checks. |
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
fhanik
approved these changes
May 5, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #3655