Skip to content

Fix potential ClassCastException during shadow user create #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strehle merged 3 commits into from
May 5, 2026
Merged

Fix potential ClassCastException during shadow user create #3893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0e575b
Fix potential ClassCastException during shadow user create
strehle May 4, 2026
9f47417
refactor based on review
strehle May 4, 2026
2b1d175
review
strehle May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthAuthenticationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,11 @@ private boolean isRegisteredIdpAuthentication(Authentication request) {

@Override
protected boolean isAddNewShadowUser(final String origin) {
IdentityProvider<AbstractExternalOAuthIdentityProviderDefinition> provider = getProviderProvisioning().retrieveByOrigin(origin, identityZoneManager.getCurrentIdentityZoneId());
return provider.getConfig().isAddShadowUserOnLogin();
IdentityProvider<?> provider = getProviderProvisioning().retrieveByOrigin(origin, identityZoneManager.getCurrentIdentityZoneId());
if (provider.getConfig() instanceof AbstractExternalOAuthIdentityProviderDefinition<?> config) {
return config.isAddShadowUserOnLogin();
}
return false;
}

public RestTemplate getRestTemplate(AbstractExternalOAuthIdentityProviderDefinition config) {
Expand Down
11 changes: 11 additions & 0 deletions ...va/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthAuthenticationManagerIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import org.cloudfoundry.identity.uaa.provider.IdentityProvider;
import org.cloudfoundry.identity.uaa.provider.IdentityProviderProvisioning;
import org.cloudfoundry.identity.uaa.provider.OIDCIdentityProviderDefinition;
import org.cloudfoundry.identity.uaa.provider.UaaIdentityProviderDefinition;
import org.cloudfoundry.identity.uaa.provider.RawExternalOAuthIdentityProviderDefinition;
import org.cloudfoundry.identity.uaa.provider.oauth.ExternalOAuthAuthenticationManager.AuthenticationData;
import org.cloudfoundry.identity.uaa.scim.ScimGroupExternalMember;
Expand Down Expand Up @@ -305,6 +306,16 @@ public URL getAuthUrl() {
.hasMessage("Unknown type for provider.");
}

@Test
void isAddNewShadowUser_returnsFalse_whenProviderConfigIsNotExternalOAuth() {
IdentityProvider<UaaIdentityProviderDefinition> provider = new IdentityProvider<>();
provider.setType(OriginKeys.UAA);
provider.setConfig(new UaaIdentityProviderDefinition());
when(provisioning.retrieveByOrigin(eq(ORIGIN), anyString())).thenReturn(provider);

assertThat(externalOAuthAuthenticationManager.isAddNewShadowUser(ORIGIN)).isFalse();
}

@Test
void verify_hmac_256_signature() throws Exception {
String key = "key";
Expand Down
Loading