v1.404.0

fix: ECS Cluster Dan Miller (@milldr) (#987)

what

• Fixed ACM Certificate lookup
• Upgrade alb module
• Resolve all tflint warnings

why

• The default ACM certificate should have the regional domain. ECS is a regional resource, and with our architecture we include the environment in the domain. TLDR the default should be use1.dev.plat.acme.com not dev.plat.acme.com
• Upgrade alb to use the latest included S3 module, with the updated requirements for adding S3 Bucket ACLs
• Support tflint

references

• customer engagement
• example tflint warnings:

Warning: [Fixable] List items should be accessed using square brackets (terraform_deprecated_index)

  on main.tf line 84:
  84:         security_group_ids          = concat(aws_security_group.default.*.id, provider.security_group_ids)

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_index.md

Warning: [Fixable] Comparing a collection with an empty list is invalid. To detect an empty collection, check its length. (terraform_empty_list_equality)

  on main.tf line 237:
 237:     "${config_key}_${domain}" => domain } if lookup(config, "additional_certs", []) != []

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_empty_list_equality.md

Warning: [Fixable] variable "default_capacity_strategy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 236:
 236: variable "default_capacity_strategy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md