Skip to content

Fix invalid use of FileCacher in DownloadTestcasesHandler #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veluca93 merged 1 commit into from
Jun 9, 2025
Merged

Fix invalid use of FileCacher in DownloadTestcasesHandler #1400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions cms/server/admin/handlers/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,15 +621,12 @@ def post(self, dataset_id):
temp_file = io.BytesIO()
with zipfile.ZipFile(temp_file, "w") as zip_file:
for testcase in dataset.testcases.values():
# Get input, output file path
with self.service.file_cacher.get_file(testcase.input) as f:
input_path = f.name
with self.service.file_cacher.get_file(testcase.output) as f:
output_path = f.name
zip_file.write(
input_path, input_template % testcase.codename)
zip_file.write(
output_path, output_template % testcase.codename)
# Copy input file
with zip_file.open(input_template % testcase.codename, 'w') as fout:
self.service.file_cacher.get_file_to_fobj(testcase.input, fout)
# Copy output file
with zip_file.open(output_template % testcase.codename, 'w') as fout:
self.service.file_cacher.get_file_to_fobj(testcase.output, fout)

self.set_header("Content-Type", "application/zip")
self.set_header("Content-Disposition",
Expand Down