Skip to content

fix(ci): allow fork PR checkout in tags.yaml pull_request_target workflow - #2275

Merged
riaankleinhans merged 1 commit into
cncf:mainfrom
chadmcrowell:fix/allow-fork-checkout-tags-workflow
Aug 12, 2026
Merged

fix(ci): allow fork PR checkout in tags.yaml pull_request_target workflow#2275
riaankleinhans merged 1 commit into
cncf:mainfrom
chadmcrowell:fix/allow-fork-checkout-tags-workflow

Conversation

@chadmcrowell

Copy link
Copy Markdown
Contributor

Summary

  • actions/checkout now refuses by default to check out a fork PR's head ref inside a pull_request_target workflow (the "pwn request" guard).
  • This blocks tags_yaml_fork_pr_processing.yaml for any fork PR that touches tags.yaml, e.g. fix links to youtube and meeting notes for TAG OpRes #2274.
  • This job is safe to opt in: it never executes fork-supplied code. After checkout it resets the working tree to origin/main and only carries over tags.yaml (data, not code) before running generator/readme_app.go from main.

Fix

Add allow-unsafe-pr-checkout: true to the checkout step, per https://gh.io/securely-using-pull_request_target.

Test plan

…flow

actions/checkout now refuses to check out fork PR heads under
pull_request_target by default. This job never executes fork-supplied
code (it resets to origin/main before running the generator, only
carrying over tags.yaml as data), so it's safe to opt back in.

Signed-off-by: chadmcrowell <chadmcrowell@gmail.com>
@chadmcrowell
chadmcrowell requested review from a team as code owners August 12, 2026 14:06
@riaankleinhans
riaankleinhans merged commit bde2000 into cncf:main Aug 12, 2026
1 of 2 checks passed

@salaboy salaboy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust @chadmcrowell changes here and he is blocked by this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants