GCI: Update tasks - #215
Open
jayvdb wants to merge 1 commit into
Open
Conversation
gitmate-bot
reviewed
Oct 23, 2018
| if not isinstance(old_value, set): | ||
| print(f'wtf {key} {type(value)}') | ||
| if old_value > value: | ||
| print(f'{key}: {sorted(old_value)} - {sorted(old_value - value)}') |
Collaborator
There was a problem hiding this comment.
E501 line too long (82 > 80 characters)
Origin: PycodestyleBear (E501), Section: all.python.default.
gitmate-bot
reviewed
Oct 23, 2018
| if old_value > value: | ||
| print(f'{key}: {sorted(old_value)} - {sorted(old_value - value)}') | ||
| elif value > old_value: | ||
| print(f'{key}: {sorted(old_value)} + {sorted(value - old_value)}') |
Collaborator
There was a problem hiding this comment.
E501 line too long (82 > 80 characters)
Origin: PycodestyleBear (E501), Section: all.python.default.
gitmate-bot
reviewed
Oct 23, 2018
| print(f'{key} (REMOVED): {sorted(removed)}\n' | ||
| f'{indent} (NEW): {sorted(added)}') | ||
| continue | ||
| elif len(lines) == len(old_lines) and len(common_lines) == len(lines) - 1: |
Collaborator
There was a problem hiding this comment.
E501 line too long (82 > 80 characters)
Origin: PycodestyleBear (E501), Section: all.python.default.
gitmate-bot
reviewed
Oct 23, 2018
| common_lines = lines.intersection(old_lines) | ||
| if lines < old_lines: | ||
| print(f'{key} (REMOVED LINES):\n') | ||
| for line in new_lines: |
Collaborator
There was a problem hiding this comment.
undefined name 'new_lines'
Origin: PyFlakesBear, Section: all.python.default.
gitmate-bot
reviewed
Oct 23, 2018
| if not isinstance(old_value, set): | ||
| print(f'wtf {key} {type(value)}') | ||
| if old_value > value: | ||
| print(f'{key}: {sorted(old_value)} - {sorted(old_value - value)}') |
Collaborator
There was a problem hiding this comment.
Line is longer than allowed. (82 > 80)
Origin: LineLengthBear, Section: all.linelength.
gitmate-bot
reviewed
Oct 23, 2018
| if old_value > value: | ||
| print(f'{key}: {sorted(old_value)} - {sorted(old_value - value)}') | ||
| elif value > old_value: | ||
| print(f'{key}: {sorted(old_value)} + {sorted(value - old_value)}') |
Collaborator
There was a problem hiding this comment.
Line is longer than allowed. (82 > 80)
Origin: LineLengthBear, Section: all.linelength.
gitmate-bot
reviewed
Oct 23, 2018
| print(f'{key} (REMOVED): {sorted(removed)}\n' | ||
| f'{indent} (NEW): {sorted(added)}') | ||
| continue | ||
| elif len(lines) == len(old_lines) and len(common_lines) == len(lines) - 1: |
Collaborator
There was a problem hiding this comment.
Line is longer than allowed. (82 > 80)
Origin: LineLengthBear, Section: all.linelength.
Travis tests have failedHey @jayvdb, 1st Buildpytestcoala --non-interactive -VTravisBuddy Request Identifier: 1abf0b80-d6b6-11e8-a0c1-37e29dcbd83a |
Travis tests have failedHey @jayvdb, 1st Buildpytestcoala --non-interactive -VTravisBuddy Request Identifier: 15c3ebf0-d6bb-11e8-a0c1-37e29dcbd83a |
Travis tests have failedHey @jayvdb, 1st Buildpytestcoala --non-interactive -VTravisBuddy Request Identifier: 8846fef0-d6bc-11e8-a0c1-37e29dcbd83a |
Travis tests have failedHey @jayvdb, 1st Buildpytestcoala --non-interactive -VTravisBuddy Request Identifier: a6c47810-d6d2-11e8-a0c1-37e29dcbd83a |
Travis tests have failedHey @jayvdb, 1st BuildpytestTravisBuddy Request Identifier: 796b3f90-d6d5-11e8-a0c1-37e29dcbd83a |
jayvdb
force-pushed
the
update-taks
branch
2 times, most recently
from
October 26, 2018 06:32
439de8b to
9107902
Compare
gitmate-bot
reviewed
Oct 26, 2018
| elif len(added) <= 3 and len(removed) <= 3: | ||
| if removed: | ||
| print(f'{key} (REMOVED): {sorted(removed)}') | ||
| if remove and added: |
Collaborator
There was a problem hiding this comment.
undefined name 'remove'
Origin: PyFlakesBear, Section: all.python.default.
Travis tests have failedHey @jayvdb, 1st Buildpytestcoala --non-interactive -VTravisBuddy Request Identifier: 246006e0-d8ea-11e8-b9f2-b1fbc111596d |
Contributor
|
@jayvdb The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rather large sprawling set of changes.