Skip to content

Update build-ceph-custom.yml - #8

Closed
senolcolak wants to merge 1 commit into
mainfrom
senolcolak-patch-1
Closed

Update build-ceph-custom.yml#8
senolcolak wants to merge 1 commit into
mainfrom
senolcolak-patch-1

Conversation

@senolcolak

@senolcolak senolcolak commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

non-existing build packages are breaking the build cylce. removed that.

Closes cobaltcore-dev/cloud-storage#

Backport file

  • release-management/backports/<uuid>.md added (or updated) by this PR
  • id in frontmatter matches the filename stem
  • provenance.upstream_prs set (or provenance.type: other with an other: block)

Stage-B risk (filled per release-management/backports/RISK-RUBRIC.md)

  • blast — cosmetic / availability / data-loss
  • conflict — clean / trivial / substantive
  • coverage — strong / partial / weak
  • Risk-notes paragraph in the prose section (required for high band)

Merge

Land this via just merge-backport PR=<N> — do not click the green merge button.
The just recipe constructs the merge commit's Backport-Id trailer.

Summary by CodeRabbit

  • Chores
    • Improved reliability of the Ceph RPM build process with stricter error handling.
    • Added clearer logging for selected build parallelism.
    • Updated build configuration to use the computed job count consistently.
    • Simplified compiler option handling for containerized builds.

non-existing build packages are breaking the build cylce. removed that.

Signed-off-by: Senol Colak <senol.colak@sap.com>
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Ceph custom build workflow now uses strict shell error handling, reports the computed Ninja parallelism, exports NINJAJOBS, and omits explicit CMake options for build type, LTO, and tests.

Changes

Ceph custom build workflow

Layer / File(s) Summary
Compile step execution
.github/workflows/build-ceph-custom.yml
The compile step enables set -euo pipefail, logs the computed Ninja job count, exports NINJAJOBS, and removes explicit CMake options for RelWithDebInfo, LTO, and tests.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the build failure but leaves the required issue linkage, backport file, and Stage-B risk checklist incomplete. Add the backport candidate issue number, commit the required backport file, complete the Stage-B risk fields, and add risk notes when required.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the changed workflow file and relates to the build configuration update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch senolcolak-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build-ceph-custom.yml:
- Around line 106-112: Update the build-with-container.py invocation to pass the
job count into the container via --extra "-eNPROC=${JOBS}", since the RPM build
path’s get_processors() reads NPROC. Replace or adjust the surrounding log to
report the NPROC value actually passed, while retaining the existing centos9
packages build options.
- Around line 99-104: Update the JOBS calculation in the build workflow to use
memory available to the build, such as MemAvailable or the applicable cgroup
memory limit, with headroom instead of MemTotal. Preserve the CPU upper bound,
and only enforce the minimum of two jobs when the runner has sufficient memory
to support it; otherwise allow a lower job count.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ddc2279d-6062-4802-87ab-9578f5e6661d

📥 Commits

Reviewing files that changed from the base of the PR and between 4e9cd74 and 0f19f29.

📒 Files selected for processing (1)
  • .github/workflows/build-ceph-custom.yml

Comment thread .github/workflows/build-ceph-custom.yml
Comment thread .github/workflows/build-ceph-custom.yml
@senolcolak

Copy link
Copy Markdown
Collaborator Author

I will merge to another branch

@senolcolak senolcolak closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants