Update build-ceph-custom.yml - #8
Closed
senolcolak wants to merge 1 commit into
Closed
Conversation
non-existing build packages are breaking the build cylce. removed that. Signed-off-by: Senol Colak <senol.colak@sap.com>
📝 WalkthroughWalkthroughThe Ceph custom build workflow now uses strict shell error handling, reports the computed Ninja parallelism, exports ChangesCeph custom build workflow
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zoorpha
approved these changes
Aug 6, 2026
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-ceph-custom.yml:
- Around line 106-112: Update the build-with-container.py invocation to pass the
job count into the container via --extra "-eNPROC=${JOBS}", since the RPM build
path’s get_processors() reads NPROC. Replace or adjust the surrounding log to
report the NPROC value actually passed, while retaining the existing centos9
packages build options.
- Around line 99-104: Update the JOBS calculation in the build workflow to use
memory available to the build, such as MemAvailable or the applicable cgroup
memory limit, with headroom instead of MemTotal. Preserve the CPU upper bound,
and only enforce the minimum of two jobs when the runner has sufficient memory
to support it; otherwise allow a lower job count.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ddc2279d-6062-4802-87ab-9578f5e6661d
📒 Files selected for processing (1)
.github/workflows/build-ceph-custom.yml
zoorpha
approved these changes
Aug 6, 2026
Collaborator
Author
|
I will merge to another branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
non-existing build packages are breaking the build cylce. removed that.
Closes cobaltcore-dev/cloud-storage#
Backport file
release-management/backports/<uuid>.mdadded (or updated) by this PRidin frontmatter matches the filename stemprovenance.upstream_prsset (orprovenance.type: otherwith another:block)Stage-B risk (filled per
release-management/backports/RISK-RUBRIC.md)blast— cosmetic / availability / data-lossconflict— clean / trivial / substantivecoverage— strong / partial / weakhighband)Merge
Land this via
just merge-backport PR=<N>— do not click the green merge button.The just recipe constructs the merge commit's
Backport-Idtrailer.Summary by CodeRabbit