logical: fix handling of tenants #156715
Merged
logical: fix handling of tenants #156715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy sql writer and the kv writer both have this logic for stripping tenant prefixes before decoding the key. This was uncovered because cockroachdb#156510 enabled metamorphic multi-tenancy for the LDR tests. Release note: none Fixes: cockroachdb#156640
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
dt
approved these changes
Nov 3, 2025
|
Thanks for the review! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy sql writer and the kv writer both have this logic for stripping tenant prefixes before decoding the key. This was uncovered because #156510 enabled metamorphic multi-tenancy for the LDR tests.
Release note: none
Fixes: #156640