Skip to content

roachtest: use title override for schema change workload failures#169578

Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
msbutler:butler-schema-change-issue
May 4, 2026
Merged

roachtest: use title override for schema change workload failures#169578
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
msbutler:butler-schema-change-issue

Conversation

@msbutler
Copy link
Copy Markdown
Collaborator

@msbutler msbutler commented May 1, 2026

Schema change workload failures in DR roachtests (backup-restore,
c2c) are rerouted to sql-foundations via ErrorWithOwner. However,
since issue deduplication is title-based, a subsequent non-schema-change
failure would match the existing sql-foundations issue instead of
creating a new one for disaster-recovery.

Add a TitleOverride so schema change workload failures get a distinct
issue title ("schema_change_workload_failure"), preventing dedup
collisions with real DR test failures.

Epic: none
Release note: None

Schema change workload failures in DR roachtests (backup-restore,
c2c) are rerouted to sql-foundations via ErrorWithOwner. However,
since issue deduplication is title-based, a subsequent non-schema-change
failure would match the existing sql-foundations issue instead of
creating a new one for disaster-recovery.

Add a TitleOverride so schema change workload failures get a distinct
issue title ("schema_change_workload_failure"), preventing dedup
collisions with real DR test failures.

Epic: none
Release note: None

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@msbutler msbutler self-assigned this May 1, 2026
@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented May 1, 2026

😎 Merged successfully - details.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@msbutler msbutler marked this pull request as ready for review May 1, 2026 19:25
@msbutler msbutler requested a review from a team as a code owner May 1, 2026 19:25
@msbutler msbutler requested review from cpj2195, golgeek and spilchen and removed request for a team May 1, 2026 19:25
Copy link
Copy Markdown
Contributor

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msbutler
Copy link
Copy Markdown
Collaborator Author

msbutler commented May 4, 2026

TFTR!

/trunk merge

@msbutler msbutler added the backport-all Flags PRs that need to be backported to all supported release branches label May 4, 2026
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 4, 2026

Detected infrastructure failure on trunk-merge branch (matched: self-hosted runner lost communication with the server). Automatically resubmitting to merge queue (attempt 1 of 2). (run link)

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 4, 2026

/trunk merge

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 4, 2026

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


merge conflict cherry-picking 35f4fd1 to blathers/backport-release-24.3-169578

Backport to branch release-24.3 failed. See errors above.


merge conflict cherry-picking 35f4fd1 to blathers/backport-release-25.2-169578

Backport to branch release-25.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all Flags PRs that need to be backported to all supported release branches backport-failed target-release-26.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants