Skip to content

release-26.1: roachtest: use title override for schema change workload failures#169691

Open
msbutler wants to merge 2 commits intocockroachdb:release-26.1from
msbutler:blathers/backport-release-26.1-169578
Open

release-26.1: roachtest: use title override for schema change workload failures#169691
msbutler wants to merge 2 commits intocockroachdb:release-26.1from
msbutler:blathers/backport-release-26.1-169578

Conversation

@msbutler
Copy link
Copy Markdown
Collaborator

@msbutler msbutler commented May 4, 2026

Backport 1/1 commits from #169578 on behalf of @msbutler.


Schema change workload failures in DR roachtests (backup-restore,
c2c) are rerouted to sql-foundations via ErrorWithOwner. However,
since issue deduplication is title-based, a subsequent non-schema-change
failure would match the existing sql-foundations issue instead of
creating a new one for disaster-recovery.

Add a TitleOverride so schema change workload failures get a distinct
issue title ("schema_change_workload_failure"), preventing dedup
collisions with real DR test failures.

Epic: none
Release note: None


Release justification: test only change

Schema change workload failures in DR roachtests (backup-restore,
c2c) are rerouted to sql-foundations via ErrorWithOwner. However,
since issue deduplication is title-based, a subsequent non-schema-change
failure would match the existing sql-foundations issue instead of
creating a new one for disaster-recovery.

Add a TitleOverride so schema change workload failures get a distinct
issue title ("schema_change_workload_failure"), preventing dedup
collisions with real DR test failures.

Epic: none
Release note: None

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@msbutler msbutler requested a review from a team as a code owner May 4, 2026 18:55
@msbutler msbutler force-pushed the blathers/backport-release-26.1-169578 branch from ce6eae1 to c08badd Compare May 4, 2026 18:55
@msbutler msbutler requested review from herkolategan and shailendra-patel and removed request for a team May 4, 2026 18:55
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 4, 2026
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 4, 2026

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented May 4, 2026

Merging to release-26.1 in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-disaster-recovery labels May 4, 2026
@blathers-crl blathers-crl Bot requested review from cpj2195, golgeek and spilchen May 4, 2026 18:55
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 4, 2026

Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link)

Copy link
Copy Markdown
Collaborator

@herkolategan herkolategan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires --rewrite to address the unit test failures on CI.

The backported testdata file was generated on master which includes a
Datadog log link in the help section. Release-26.1 does not have this
feature, so the testdata needs to be regenerated.

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 5, 2026

Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link)

@blathers-crl blathers-crl Bot added backport-test-only Used to denote the backport has only non-production changes and removed backport-failed labels May 5, 2026
@msbutler msbutler requested a review from herkolategan May 5, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-disaster-recovery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants