localmetrics: add local Grafana timeseries tooling#50702
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jun 30, 2020
Merged
localmetrics: add local Grafana timeseries tooling#50702craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Release note: None
Member
|
This change is |
petermattis
approved these changes
Jun 26, 2020
Collaborator
petermattis
left a comment
petermattis
left a comment
There was a problem hiding this comment.
This is neat!
sample.csv is pretty large. Is it it worth including?
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @lunevalex and @petermattis)
Member
Author
Don't think it would've mattered, but I moved it to a gist instead, so it's gone now. TFTR bors r=petermattis |
Contributor
Build failed |
Member
Author
|
bors r=petermattis Lint |
Contributor
Build failed |
Member
Author
|
lint fails with:
Probably @jordanlewis knows what to make of that, but it doesn't seem to be this PR's fault. |
Member
Author
|
bors r=petermattis master is probably fixed now. |
craig Bot
pushed a commit
that referenced
this pull request
Jun 27, 2020
50702: localmetrics: add local Grafana timeseries tooling r=petermattis a=tbg Add a docker-compose setup that starts a local Grafana backed by a local Postgres along with a helper that can import timeseries data into the Postgres instance which the Grafana instance is configured to display. Consult scripts/localmetrics/README.md for a quickstart. This isn't a valuable debug tool just yet, but with a bit of elbow grease, I believe that it will become an invaluable tool to avoid the many back-and-forth round-trips we have these days with customers to exchange screenshots of the Admin UI. To make it truly useful, we need 1. [timeseries in debug.zip](#50432) 2. auto-generate dashboards from `./pkg/ts/catalog`. Both are totally doable, and even without 2) there's already some utility as it's easy to make ad-hoc panels in Grafana thanks to the built-in query builder. Finally, here's a screenshot of the one panel included here right now, the rate of DistSender batches, taken from `sample.csv`.  Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Contributor
Build failed |
Add a docker-compose setup that starts a local Grafana backed by a local Postgres along with a helper that can import timeseries data into the Postgres instance which the Grafana instance is configured to display. Consult scripts/localmetrics/README.md for a quickstart. This isn't a valuable debug tool just yet, but with a bit of elbow grease, I believe that it will become an invaluable tool to avoid the many back-and-forth round-trips we have these days with customers to exchange screenshots of the Admin UI. To make it truly useful, we need 1. [timeseries in debug.zip](cockroachdb#50432) 2. auto-generate dashboards from `./pkg/ts/catalog`. Both are totally doable, and even without 2) there's already some utility as it's easy to make ad-hoc panels in Grafana thanks to the built-in query builder. Release note: None
Member
Author
|
bors r=petermattis |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a docker-compose setup that starts a local Grafana backed by a local
Postgres along with a helper that can import timeseries data into the
Postgres instance which the Grafana instance is configured to display.
Consult scripts/localmetrics/README.md for a quickstart.
This isn't a valuable debug tool just yet, but with a bit of elbow
grease, I believe that it will become an invaluable tool to avoid
the many back-and-forth round-trips we have these days with customers
to exchange screenshots of the Admin UI.
To make it truly useful, we need
./pkg/ts/catalog.Both are totally doable, and even without 2) there's already some
utility as it's easy to make ad-hoc panels in Grafana thanks to the
built-in query builder.
Finally, here's a screenshot of the one panel included here right now,
the rate of DistSender batches, taken from
sample.csv.Release note: None