Skip to content

[prototype/WIP] widened side grid - #3205

Closed
j-low wants to merge 1 commit into
masterfrom
widen_site_grid_prototype
Closed

[prototype/WIP] widened side grid#3205
j-low wants to merge 1 commit into
masterfrom
widen_site_grid_prototype

Conversation

@j-low

@j-low j-low commented May 30, 2018

Copy link
Copy Markdown
Contributor

[description]:

  • rough draft for what a widened site grid would appear as on docs

@cockroach-teamcity

Copy link
Copy Markdown
Member

This change is Reviewable

@j-low j-low changed the title [prototype] widened side grid [prototype/WIP] widened side grid May 30, 2018
@j-low

j-low commented May 30, 2018

Copy link
Copy Markdown
Contributor Author

cc: @jseldess

@cockroach-teamcity

Copy link
Copy Markdown
Member

@jseldess

Copy link
Copy Markdown
Contributor

This is cool, @j-low. One quick comment: Instead of letting the main body expand to the right indefinitely, I think we want a max width. While we're doing this, we should move the page-level TOC to a right margin. @kuanluo mocked this up a bit here: #2195 (comment)

Some decent examples of using the right margin for page TOC:

@j-low

j-low commented May 31, 2018

Copy link
Copy Markdown
Contributor Author

@jseldess sure thing...there will be progressive updates to this PR. I'll be working on that third column for the TOC next.

@jseldess

jseldess commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

For clarity, I'm closing this in favor of the more recent #3284.

@jseldess jseldess closed this Jul 4, 2018
@madelynnblue
madelynnblue deleted the widen_site_grid_prototype branch August 20, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants