Use Brand helper class in LTI iframe view#73085
Merged
Merged
Conversation
stephenliang
approved these changes
Jun 4, 2026
stephenliang
left a comment
stephenliang
left a comment
Member
There was a problem hiding this comment.
Although note the merge conflict
Signed-off-by: Nick Lathe <nick.lathe@code.org>
nicklathe
force-pushed
the
use-brand-lti-iframe
branch
from
June 4, 2026 22:02
93f67cb to
dea9a67
Compare
carl-codeorg
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Cdo::Brand.logo_filenamehelper method instead of hardcoding filename.Links
Testing story
Deployment notes
Privacy and security