Labs/applab design mode workspace rebrand - #73932
Merged
Merged
Conversation
🖼️ Storybook Visual Comparison Report✅ No Storybook eyes differences detected! |
wilkie
changed the title
wilkie
marked this pull request as ready for review
July 17, 2026 09:17
wilkie
force-pushed
the
labs/applab-design-toolbox-rebrand
branch
from
July 21, 2026 06:30
8a00407 to
dd2a953
Compare
wilkie
force-pushed
the
labs/applab-design-toolbox-rebrand
branch
from
July 23, 2026 10:54
dd2a953 to
5a9a1c5
Compare
ebeastlake
reviewed
Jul 24, 2026
| var element = document.getElementById(newId); | ||
| if (element && !$('#divApplab').find(element)[0]) { | ||
| return false; | ||
| return 'That ID is reserved. Choose a different one.'; |
Contributor
There was a problem hiding this comment.
Might be answered elsewhere in this PR: Did these strings change?
Contributor
Author
There was a problem hiding this comment.
Oh right. The text fields support an error string and Claude was like 'let's add the errors so folks know what the problem is since we figure that out anyway and feed it to the new text field' and I'm like 'OK that's a simple improvement sure sure why not'.
ebeastlake
reviewed
Jul 24, 2026
ebeastlake
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
This does not (will be done in a follow-up):
Screenshots
Before
Normal
id Property Error
Lockable Properties (label)
Copy to Screen Popup Menu
Element dropdown
Options Property (textarea)
Color Property
Color Picker
Boolean Property (checked)
Textarea
Depth Property
Delete Confirmation
Events Tab
Audit
Links