Lab2: fix for project blocked ui bug - #74306
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Lab2 “project blocked” UI behavior for level URLs (/levels/<id>), ensuring those pages are treated as level pages (not share pages) so editing is not incorrectly blocked when privacy/profanity filtering flags content.
Changes:
- Extend
getLabViewPageActionto recognize standalone/levels/...URLs aslevel. - Add unit tests covering project URLs, course level URLs, and standalone
/levels/...URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/src/lab2/utils/getLabViewPageAction.ts | Updates URL parsing so /levels/<id> is categorized as level for downstream blocked-UI logic. |
| apps/test/unit/lab2/utils/getLabViewPageActionTest.ts | Adds coverage for getLabViewPageAction across project, level, and non-matching URLs. |
molly-moen
marked this pull request as ready for review
July 31, 2026 15:47
fisher-alice
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After I added profanity filtering to Sketch Lab, Eric hit an issue where the
/levels/<level-id>url would block you from editing if you added anything we flagged as profanity. The reason was ourgetLabViewPageActionfunction didn't account for/levelsurls, and therefore we assumed we were on some sort of share page.Before
After
Links
Testing story
Tested locally and added unit tests.