refactor(ui): common-ui module + reusable ChatListRow + MediaItem rendition fallback - #1119
Merged
Merged
Conversation
…dition fallback - Move ContactAvatar into a new shared common-ui module (adds a UserProfile overload). - Split chat-ui models (ChatAction/ChatListItem/SeparatorConfig) out of the ui package into chat/models. - Add a slot-based ChatListRow primitive plus reusable ChatRowTrailing/ChatRowSubtitle (ChatRowContent); migrate ContactList and messenger onto them. - Add MediaItem.rendition/url with graceful rendition fallback (+ MediaItemTest). - CircularIconButton: add imageSize/buttonSize overrides.
github-actions
Bot
added
type: refactor
bmc08gt
added a commit
that referenced
this pull request
Jul 24, 2026
…dition fallback (#1119) - Move ContactAvatar into a new shared common-ui module (adds a UserProfile overload). - Split chat-ui models (ChatAction/ChatListItem/SeparatorConfig) out of the ui package into chat/models. - Add a slot-based ChatListRow primitive plus reusable ChatRowTrailing/ChatRowSubtitle (ChatRowContent); migrate ContactList and messenger onto them. - Add MediaItem.rendition/url with graceful rendition fallback (+ MediaItemTest). - CircularIconButton: add imageSize/buttonSize overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundational chat/contact UI refactor — no user-facing behavior change. First of a small series toward the tipping feature.
Changes
common-uimodule: extractContactAvatarout ofcontactsinto a new sharedcommon-uimodule, and add aUserProfileoverload (uses the newMediaItemaccessor for its rendition).ChatAction/ChatListItem/SeparatorConfigout of theuipackage intochat/models(pure moves).ChatListRow(avatar / title / subtitle / trailing) plusChatRowContent(ChatRowTrailing,ChatRowSubtitle,SubtitleText) so conversation rows (contacts, and tip chats later) share the timestamp / unread-badge / preview logic. Migratedirect-send's contact row and the messenger consumers onto them.MediaItem.rendition(role)/url(role): request a rendition and gracefully fall back down the quality ladder (ORIGINAL → DISPLAY → THUMBNAIL → null), skipping renditions whose blob isn't ready (+ unit test).CircularIconButton: addimageSize/buttonSizeoverrides (backward-compatible defaults).Testing
./gradlew :apps:flipcash:app:assembleDebug— BUILD SUCCESSFUL (built standalone offcode/cash):services:flipcashMediaItemTestpasses