refactor(scannable): render Scannables through the bill container - #1120
Merged
Conversation
- Reorganize bills: RenderedBill -> ScannableRenderer, AnimatedBill ->
AnimatedScannable, composables into components/{bills,cards,receipts}
(adds the TipCard renderer); BillContainerView -> ScannableContainer.
- Widen BillState.bill to Scannable? and add SessionController.showTipCard so a
non-payment tip card can be presented in the container (no grab/valuation);
add tip SessionState fields wired to the new Tipping feature flag.
- Theme: add the tipCard color token; bump the xxl corner shape.
- Incidental: enable Gradle parallel tooling; small ResolverService refactor.
github-actions
Bot
added
type: refactor
bmc08gt
added a commit
that referenced
this pull request
Jul 24, 2026
) - Reorganize bills: RenderedBill -> ScannableRenderer, AnimatedBill -> AnimatedScannable, composables into components/{bills,cards,receipts} (adds the TipCard renderer); BillContainerView -> ScannableContainer. - Widen BillState.bill to Scannable? and add SessionController.showTipCard so a non-payment tip card can be presented in the container (no grab/valuation); add tip SessionState fields wired to the new Tipping feature flag. - Theme: add the tipCard color token; bump the xxl corner shape. - Incidental: enable Gradle parallel tooling; small ResolverService refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors bill rendering into a general "Scannable" container so non-payment scannables (tip cards) can be presented alongside cash bills. No new user-facing feature. Second of the tipping series (after #1119).
Changes
RenderedBill→ScannableRenderer,AnimatedBill→AnimatedScannable; composables moved intocomponents/{bills,cards,receipts}(adds theTipCardrenderer).BillContainerView→ScannableContainer.Scannable:BillState.billbecomesScannable?;SessionController.showTipCard(tipCard)presents a non-payment tip card (no grab/valuation), and the container folds the management options / confirmation modal per scannable type.isTippingEnabled/tipsUnreadCounttoSessionState, wired to a newTippingfeature flag.tipCardcolor token; bump thexxlcorner shape 25→30dp.gradle.properties); minorResolverServiceresponse refactor.Testing
./gradlew :apps:flipcash:app:assembleDebug— BUILD SUCCESSFUL (built standalone offcode/cash).