Conversation
towards https://linear.app/ghost/issue/NY-1163 This change should have no user impact. Just fixes a type error when this test function was used.
no ref Before this change, `foo #ff9900` was considered a valid hex color. After this change, it is not. I believe it's difficult to have bad data in the database, but if that happens, we want to check it properly.
…26960) ## Problem `@site.admin_url` was using `getAdminUrl()` which returns the base admin domain (e.g. `https://admin.example.com/`) **without** `/ghost/`. This means the "Site owner login" link on the private page pointed to the domain root instead of the admin panel for any site with a separate admin URL configured (including all Ghost(Pro) sites). ## Fix Changed `update-local-template-options.js` to use `urlFor('admin', true)` which correctly appends `/ghost/` to the admin URL. ## Test Added a test that stubs `getAdminUrl()` with a separate domain (`https://admin.example.com/`) and asserts the resulting `admin_url` ends with `/ghost/`. This test fails on main and passes with the fix.
no ref
- adds stable Portal offer-page test ids for title, discount label,
message, and updated price
- simplifies the Portal offer page object to expose plain locators
instead of text-specific helper methods
- hides paid-tier Stripe readiness behind createPaidPortalTier(...,
{stripe})
- reduces repeated assertion blocks in portal-offers.test.ts with local
expectation helpers
- teaches the e2e Playwright lint rule to recognize local expect...
assertion helpers
closes https://linear.app/ghost/issue/NY-1178 towards https://linear.app/ghost/issue/NY-1163 This was written almost entirely by Claude Opus 4.6 against the following prompt: > I want to create a snapshot test for member welcome emails. We currently have _some_ tests for this, like in `ghost/core/test/e2e-api/admin/automated-emails.test.js` and `ghost/core/test/integration/services/member-welcome-emails.test.js`, but these don't assert on the final rendered output. > > Build a (test-only) change that renders the full HTML of a member welcome email, and asserts on the snapshot. We have `assertMatchSnapshot` for this purpose, which I reckon you should use. I reviewed the code thoroughly and made a couple of small tweaks.
ref https://linear.app/ghost/issue/FEA-480 - adds the `show_share_button` column to newsletters to prep for future share button functionality - includes the bare minimum for setting up the migration and for tests to pass. In this case it includes updating snapshots related to the newsletter - also bumps to `6.23.0-rc.0`
no ref Released new transistor.fm integration, enabling customizable Portal account settings re: podcast RSS feeds and new embed/editor card support in the editor.
closes https://linear.app/ghost/issue/NY-1105 This change should have no user impact. All it does is remove the flag, enabling the feature for everyone. In addition to automated tests, I manually verified that the new welcome email editor shows up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )