[pull] main from TryGhost:main - #1456
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/HKG-1972/migrate-update-checks-to-the-durable-jobs-interface - The worker thread bought nothing here: its shim only re-initialised settings, permissions and email-address, which the main process already has before the jobs service starts, so the same UpdateCheckService body now runs in-process and the shim is deleted rather than ported. - Both runs share a single UpdateCheckJob type because the boot and recurring identities always executed identical work; the dispatch-site "boot run queued" log keeps per-run attribution, and scheduled-vs- dispatched provenance belongs in the transport as a generic marker, not in per-job types. - The randomized full-day cron and the forceUpdate-gated boot dispatch are preserved verbatim so production behavior is unchanged; failures now also reach the jobs service's structured logging and Sentry reporting, which the Bree path lacked. Verified against pro-infra that no Elastic alert keys on the legacy update-check log shape. - Scheduling moved behind boot's try/catch like the other migrations, so a registration failure degrades to an error log instead of an unhandled rejection. - The legacy integration test drove the deleted worker file directly, so it is replaced with one that dispatches through the real jobs service and additionally asserts next_update_check advances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )