refactor: prefer described_class in specs#2725
Merged
Merged
Conversation
mroderick
marked this pull request as ready for review
July 27, 2026 09:14
olleolleolle
approved these changes
Jul 27, 2026
mroderick
enabled auto-merge
July 27, 2026 14:46
mroderick
disabled auto-merge
July 27, 2026 14:46
mroderick
force-pushed
the
refactor/use-described-class-all-specs
branch
from
July 27, 2026 15:01
ca4321f to
2d715a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adopting @olleolleolle's suggestion in #2551 (review), to use
described_classfor better ergonomics.This is part of a solution for #2554.
Use
described_classinstead of repeating class names in specs.What changed:
.rubocop_todo.yml(PR chore: enforce RuboCop across the codebase with a todo file #2726). The temporaryspec/.rubocop.ymlfrom an earlier version of this branch was removed because it is no longer needed.bundle exec rubocop -A --only RSpec/DescribedClass spec/, which corrected 135 offenses across 36 files.Layout/FirstHashElementIndentationoffense introduced by the autocorrect inspec/models/invitation_log_entry_spec.rb..rubocop_todo.ymlto reflect the reduced offense count.This makes renaming a class under test less cumbersome because the specs no longer hard-code the class name in
subject,let, mailer calls, class methods, etc.