chore: enforce RuboCop across the codebase with a todo file#2726
Merged
Conversation
- Remove `spec/**/*` from `AllCops: Exclude` and add `inherit_from: .rubocop_todo.yml` - Use `inherit_mode: merge` for `Exclude` so per-cop exclusions combine - Generate `.rubocop_todo.yml` with `--auto-gen-only-exclude --no-exclude-limit` - Add `overcommit` to the development group and configure the RuboCop hook - Add a RuboCop job to GitHub Actions
mroderick
force-pushed
the
improve/rubocop-setup
branch
from
July 27, 2026 10:03
9d728c5 to
e287590
Compare
mroderick
force-pushed
the
improve/rubocop-setup
branch
from
July 27, 2026 10:09
e287590 to
b875c22
Compare
mroderick
marked this pull request as ready for review
July 27, 2026 10:11
olleolleolle
approved these changes
Jul 27, 2026
olleolleolle
left a comment
olleolleolle
left a comment
Collaborator
There was a problem hiding this comment.
If we feel this gets in the way, somehow, it’s easy to take a step back. If it works, it’s super.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces RuboCop across the codebase, including specs.
Changes:
spec/**/*fromAllCops: Exclude..rubocop_todo.ymlwithinherit_mode: mergeforExclude, preserving existing per-cop exclusions..rubocop_todo.ymlusing--auto-gen-only-exclude --no-exclude-limit, without relaxing rules or disabling cops.overcommitas an optional pre-commit hook.docs/rubocop.mdwith contributor instructions for incremental cleanup.CI now blocks new offenses.