fix handling GatewayTimeout + fix flushing servlet request in async thread #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates? |
erikpetzold
approved these changes
Apr 29, 2022
|
Thanks for the fix! Can you please provide a test for point 3 (fixes thread local handling when flushing in async thread) that fails without your code changes. |
erikpetzold
reviewed
Jul 22, 2022
...va/de/codecentric/boot/admin/server/web/AbstractInstancesProxyControllerIntegrationTest.java
Outdated
Show resolved
Hide resolved
…in/server/web/AbstractInstancesProxyControllerIntegrationTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR:
About the last:
*.servlet.InstanceProxyControllerflushes request in different thread where no SecurityContext and other thread locals are set.request.flush()lead to incorrect context will be written to http session (see for example,org.springframework.security.web.context.SaveContextOnUpdateOrErrorResponseWrapper#onResponseCommitted).This behaviour can be disabled with startAsync() (take a look at
org.springframework.security.web.context.HttpSessionSecurityContextRepository.SaveToSessionRequestWrapper#startAsync())