fix(JournalTable): button label colors to match theme #5288
Merged
Conversation
b6199b9 to
1cbcf8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the frontend codebase, focusing on theme configuration, UI component behavior, and ESLint rules for test files. The main changes include refactoring the theme setup for better maintainability, updating UI dropdowns for improved user experience, and adjusting ESLint settings to accommodate test and spec files.
Theme configuration improvements:
index.tsby moving the PrimeVue theme initialization into a dedicatedsetupThemefunction. This also changes the color definitions for theprimarypalette to use CSS variables directly (e.g.,'var(--main-50)'instead of'rgb(var(--main-50))'), simplifying theme customization. (spring-boot-admin-server-ui/src/main/frontend/index.ts)UI component enhancements:
append-to="self"attribute to the application, instance ID, and event type filter dropdowns inJournalTable.vue. This ensures that the dropdown menus are appended to their own component, improving positioning and avoiding potential display issues. (spring-boot-admin-server-ui/src/main/frontend/views/journal/JournalTable.vue) [1] [2] [3]ESLint configuration updates:
vue/one-component-per-filerule specifically for test and spec files, allowing multiple components per file in those contexts. (spring-boot-admin-server-ui/eslint.config.mjs)closes #5254