Upgrade to plexus parent 26 - #21
Merged
Merged
Conversation
Parent 26 excludes **/src/site/markdown/** from the Spotless markdown formatter, which is a prerequisite for converting this repository's site sources to Markdown: without it, flexmark rewrites the fence closing a YAML front matter block and the page loses its metadata or empties entirely. Verified by building the site on both parents and diffing the normalised output: all 73 pages are identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent bump only, kept separate from any documentation change.
Why now
Parent 26 carries
<exclude>**/src/site/markdown/**</exclude>in the Spotless configuration. That is a prerequisite for converting this repository's 65 APT pages to Markdown: on parent 25, flexmark rewrites the---fence that closes a YAML front matter block into a setext underline, and the page loses its title and author — or renders completely empty.I hit exactly that in codehaus-plexus/plexus-classworlds#149, where the first build silently emptied all three converted pages with a green
BUILD SUCCESS.So this needs to land before the APT conversion, not alongside it.
Verified safe
Built the site on both parents and diffed the normalised output of every page — title, author, visible text and link targets:
No rendered change at all.
On the APT conversion this unblocks
Worth setting expectations: it is 65 pages, and almost all of it is the retired Plexus IoC documentation. Every one of those URLs has to survive untouched — fifteen years of blog posts and Stack Overflow answers link into it — so I intend to convert page-by-page with a before/after diff each time, not in one sweep.
There is also a real question of whether it is worth converting at all. APT renders fine, nobody edits these pages, and the modello experience (codehaus-plexus/modello#576) showed
doxia-convertersilently dropping an entire HTML image map and mangling tables. I'll bring a sample of converted pages back for review before committing to the whole set.