Restore the document titles dropped when the pages were ported - #180
Merged
Conversation
Parent 26 keeps Spotless away from src/site/markdown. Its flexmark formatter rewrites the fence that closes a YAML front matter block, which silently costs each page its title.
Each APT source opened with a title block that the conversion to Markdown dropped, so every generated page took its name from the project rather than from the document. Put the titles back as YAML front matter. Only titles: none of the three APT sources carried an author or a date block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocked by the release of plexus parent 26.
Each APT source opened with a title block. Converting the pages to Markdown dropped it, so
every generated page took its name from the project instead of the document. This puts the
titles back as YAML front matter.
It could not be done before now: parent 25 runs Spotless over
**/*.md, and flexmarkrewrites the fence closing a front matter block, silently costing the page the very
metadata being restored. Parent 26 excludes
**/src/site/markdown/**, so the first commitis the parent upgrade.
Verified after the bump:
Titles only. None of
filemappers.apt,fileselectors.aptorindex.aptcarried anauthor or date block — each has a single dashed block, which APT reads as the title. I
checked the deleted sources rather than assuming, because a first pass at this had read the
body prose as an author list and produced twenty-odd bogus
author:entries per page.