Tighten offline tests and adoption diagnostics - #660
Conversation
4354835 to
16bf3f7
Compare
Code Review ✅ ApprovedTightens offline wrapper fixture to prove offline behavior with stdlib-only local build backend, identifies packaged versus explicit configuration in setup-drift text and JSON, and surfaces adoption posture hint once before provider-specific warnings. All tests pass with no issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Claude audit (merge-authority lane)Head SHA: Claude Audit: PASS Summary: Additive, well-tested changes: doctor text rendering surfaces an adoption posture hint once (verified no duplication via group filtering and matching test), migration setup-drift report/text gains a non-breaking "config_source" field, docs updated to match, and test_release_hygiene.py swaps a setuptools fixture for a minimal offline PEP 517/660 backend plus PIP_NO_INDEX to keep the venv-reinstall test network-free. No data loss, security, or contract-breaking issues found. Findings: none. |
Codex audit (merge-authority lane)Head SHA: Codex Audit: PASS Summary: No actionable correctness regressions were identified. Findings: none. |
Complete end-to-end audit of installation and documentation paths per issue #657. All acceptance criteria verified against v1.0.3 baseline (commit 1004101 with #660 and #661). Audited documentation: - Core: README, install, try-in-10-minutes, quickstart, build-loop-in-30-minutes, upgrade-existing-repo, troubleshooting, orchestrator-prompt-pack, CONTRIBUTING - Release: first-user-install-rehearsal, public-release-checklist, pypi-release, v1.0-v1.0.3 release notes - Onboarding: first-run-transcript, first-user-demo-transcript, launch-command-surface, self-hosted-mac-runner, local-audit-runner, provider-matrix, github-setup, lane-promotion-policy, cloud-sharing, planning-work-orders, builders-grok-cursor, builder-experiments Verified: - Installation paths (pipx, uv tool, editable) require Python 3.12+ - Cold install vs upgrade flows are explicitly distinct - Hosted builders directed to proper doctor posture - CLI behavior documentation consistent with tested implementation - Internal documentation links valid (manual verification of primary paths) - Privacy requirements met (no personal data in examples) Test results: - Privacy scan: pass - Ruff lint: pass - Compileall: pass - Unit tests: 863 passed - Trailing whitespace: none No documentation corrections required. The v1.0.3 documentation is accurate and internally consistent. Refs #657 Co-authored-by: Jeff Huber <jeffhuber@users.noreply.github.com>
Complete end-to-end audit of installation and documentation paths per issue #657. All acceptance criteria verified against v1.0.3 baseline (commit 1004101 with #660 and #661). Audited documentation: - Core: README, install, try-in-10-minutes, quickstart, build-loop-in-30-minutes, upgrade-existing-repo, troubleshooting, orchestrator-prompt-pack, CONTRIBUTING - Release: first-user-install-rehearsal, public-release-checklist, pypi-release, v1.0-v1.0.3 release notes - Onboarding: first-run-transcript, first-user-demo-transcript, launch-command-surface, self-hosted-mac-runner, local-audit-runner, provider-matrix, github-setup, lane-promotion-policy, cloud-sharing, planning-work-orders, builders-grok-cursor, builder-experiments Verified: - Installation paths (pipx, uv tool, editable) require Python 3.12+ - Cold install vs upgrade flows are explicitly distinct - Hosted builders directed to proper doctor posture - CLI behavior documentation consistent with tested implementation - Internal documentation links valid (manual verification of primary paths) - Privacy requirements met (no personal data in examples) Test results: - Privacy scan: pass - Ruff lint: pass - Compileall: pass - Unit tests: 863 passed - Trailing whitespace: none No documentation corrections required. The v1.0.3 documentation is accurate and internally consistent. Refs #657 Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Summary
Verification
Builder experiment
Muse CLI 1.0.2 completed the first implementation in 390.7 seconds. One orchestration correction was required for Muse CLI worktree argument syntax. Orchestrator review found one duplicate posture-hint rendering; Muse completed fix round 1 in 56.0 seconds and added regression coverage. Peer audit findings remain hidden until this PR opened.
Privacy: authoring artifacts contain metadata only; command output, source, diffs, transcripts, auth output, local paths, and secrets were not captured for upload.
Closes #656
CODE_MOWER_BUILDER:muse
CODE_MOWER_LANE:muse
CODE_MOWER_TASK_CLASS:package-runtime
CODE_MOWER_EXPERIMENT:v104-underrepresented-builder-calibration
CODE_MOWER_FINDING_DISPOSITION:accepted-fixed duplicate-posture-hint
CODE_MOWER_FIX_ROUNDS:1
CODE_MOWER_USER_INTERVENTIONS:1
CODE_MOWER_TESTS:pass
CODE_MOWER_PRIVACY:metadata-only
CODE_MOWER_END