Harden generated DISPATCH_TOKEN workflows - #661
Conversation
Use pull_request_target without checking out PR code, retaining the same-repository guard for privileged dispatch-token workflows.\n\nCloses #654\n\nCODE_MOWER_BUILDER:antigravity
ac064f2 to
a6d0460
Compare
Code Review ✅ ApprovedHardens generated DISPATCH_TOKEN workflows to run from trusted default-branch definitions via OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Codex audit (merge-authority lane)Head SHA: Codex Audit: PASS Summary: No blocking issues were found. Findings: none. |
Claude audit (merge-authority lane)Head SHA: Claude Audit: PASS Summary: Switching the agent-PR-labeler and fix-round-dispatch templates from pull_request to pull_request_target is a legitimate hardening: it pins execution to the base-branch workflow definition (so a same-repo PR branch can't tamper with the workflow steps to exfiltrate DISPATCH_TOKEN), no PR code is checked out or executed, the existing same-repo Findings: none. |
Complete end-to-end audit of installation and documentation paths per issue #657. All acceptance criteria verified against v1.0.3 baseline (commit 1004101 with #660 and #661). Audited documentation: - Core: README, install, try-in-10-minutes, quickstart, build-loop-in-30-minutes, upgrade-existing-repo, troubleshooting, orchestrator-prompt-pack, CONTRIBUTING - Release: first-user-install-rehearsal, public-release-checklist, pypi-release, v1.0-v1.0.3 release notes - Onboarding: first-run-transcript, first-user-demo-transcript, launch-command-surface, self-hosted-mac-runner, local-audit-runner, provider-matrix, github-setup, lane-promotion-policy, cloud-sharing, planning-work-orders, builders-grok-cursor, builder-experiments Verified: - Installation paths (pipx, uv tool, editable) require Python 3.12+ - Cold install vs upgrade flows are explicitly distinct - Hosted builders directed to proper doctor posture - CLI behavior documentation consistent with tested implementation - Internal documentation links valid (manual verification of primary paths) - Privacy requirements met (no personal data in examples) Test results: - Privacy scan: pass - Ruff lint: pass - Compileall: pass - Unit tests: 863 passed - Trailing whitespace: none No documentation corrections required. The v1.0.3 documentation is accurate and internally consistent. Refs #657 Co-authored-by: Jeff Huber <jeffhuber@users.noreply.github.com>
Complete end-to-end audit of installation and documentation paths per issue #657. All acceptance criteria verified against v1.0.3 baseline (commit 1004101 with #660 and #661). Audited documentation: - Core: README, install, try-in-10-minutes, quickstart, build-loop-in-30-minutes, upgrade-existing-repo, troubleshooting, orchestrator-prompt-pack, CONTRIBUTING - Release: first-user-install-rehearsal, public-release-checklist, pypi-release, v1.0-v1.0.3 release notes - Onboarding: first-run-transcript, first-user-demo-transcript, launch-command-surface, self-hosted-mac-runner, local-audit-runner, provider-matrix, github-setup, lane-promotion-policy, cloud-sharing, planning-work-orders, builders-grok-cursor, builder-experiments Verified: - Installation paths (pipx, uv tool, editable) require Python 3.12+ - Cold install vs upgrade flows are explicitly distinct - Hosted builders directed to proper doctor posture - CLI behavior documentation consistent with tested implementation - Internal documentation links valid (manual verification of primary paths) - Privacy requirements met (no personal data in examples) Test results: - Privacy scan: pass - Ruff lint: pass - Compileall: pass - Unit tests: 863 passed - Trailing whitespace: none No documentation corrections required. The v1.0.3 documentation is accurate and internally consistent. Refs #657 Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Summary
DISPATCH_TOKENfrom trusted default-branch definitions viapull_request_targetVerification
Provenance
Closes #654