🤖 fix: prevent Escape from interrupting stream during voice recording #1184
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recording voice input while streaming, pressing Escape to cancel recording would also interrupt the active chat stream. This is the same issue fixed in PR #954 (workspace renaming) and PR #1010 (message editing). Added `stopPropagation()` to the Escape handler in `useVoiceInput.ts` to prevent the event from reaching the global stream interrupt handler in `useAIViewKeybinds`. Closes #1170 --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recording voice input while streaming, pressing Escape to cancel recording would also interrupt the active chat stream. This is the same issue fixed in PR #954 (workspace renaming) and PR #1010 (message editing).
Added
stopPropagation()to the Escape handler inuseVoiceInput.tsto prevent the event from reaching the global stream interrupt handler inuseAIViewKeybinds.I explored ways to unify this pattern (centralized Escape registry, checking
defaultPrevented, single global handler with state checks) but none were better than the simplestopPropagation()approach—each adds coupling or complexity without meaningful benefit. The DOM's event propagation model is designed for exactly this case.Closes #1170
Generated with
mux