🤖 fix: improve workspace rename UI interactions #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ammar-agent
force-pushed
the
workspace-rename-ui-fix
branch
2 times, most recently
from
7c1f797 to
5484696
Compare
The X button showed 'Remove workspace' tooltip during rename mode, causing accidental workspace deletion. Now the X button is hidden while editing - users can press Escape to cancel rename instead. Also prevents Escape key from propagating to global stream interrupt handler.
ammar-agent
force-pushed
the
workspace-rename-ui-fix
branch
from
5484696 to
4d32bda
Compare
ethanndickson
added a commit
that referenced
this pull request
Dec 9, 2025
When editing a message while streaming, pressing Escape to cancel editing would also interrupt the active stream. This is the same issue fixed in PR #954 for workspace renaming. Added stopPropagation() in both code paths: - Non-vim mode: ChatInput's CANCEL_EDIT handler - Vim mode: VimTextArea's escapeInNormalMode handler This prevents the Escape keydown event from reaching the global stream interrupt handler in useAIViewKeybinds. _Generated with `mux`_
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
…#1010) When editing a message while streaming, pressing Escape to cancel editing would also interrupt the active stream. This is the same issue fixed in PR #954 for workspace renaming. Added `stopPropagation()` in both code paths: - Non-vim mode: ChatInput's CANCEL_EDIT handler - Vim mode: VimTextArea's escapeInNormalMode handler This prevents the Escape keydown event from reaching the global stream interrupt handler in `useAIViewKeybinds`. _Generated with `mux`_
ethanndickson
added a commit
that referenced
this pull request
Dec 16, 2025
When recording voice input while streaming, pressing Escape to cancel recording would also interrupt the active chat stream. This is the same issue fixed in PR #954 (workspace renaming) and PR #1010 (message editing). Added `stopPropagation()` to the Escape handler in `useVoiceInput.ts` to prevent the event from reaching the global stream interrupt handler in `useAIViewKeybinds`. Closes #1170 --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
…#1184) When recording voice input while streaming, pressing Escape to cancel recording would also interrupt the active chat stream. This is the same issue fixed in PR #954 (workspace renaming) and PR #1010 (message editing). Added `stopPropagation()` to the Escape handler in `useVoiceInput.ts` to prevent the event from reaching the global stream interrupt handler in `useAIViewKeybinds`. I explored ways to unify this pattern (centralized Escape registry, checking `defaultPrevented`, single global handler with state checks) but none were better than the simple `stopPropagation()` approach—each adds coupling or complexity without meaningful benefit. The DOM's event propagation model is designed for exactly this case. Closes #1170 --- _Generated with `mux`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides the X button during workspace rename to avoid confusion with delete.
Previously the X button would still show "Remove workspace" tooltip during rename mode, leading to accidental workspace deletion when users intended to cancel rename.
Fix: Hide the X button entirely while the rename input is active. Users can press Escape to cancel rename instead (the natural behavior).
Also prevents Escape key from propagating to global stream interrupt handler.
Generated with
mux