🤖 feat: default Grok Responses to store=false for ZDR parity - #3807
Conversation
Wire store=false through xAI provider config/options/UI and preserve encrypted reasoning metadata so multi-turn Grok quality matches non-ZDR.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce9c040e42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the P1: xAI (and OpenAI) response-storage toggles now persist via setProviderConfig before optimistic UI update, with refresh on failure — same pattern as xAI processing mode. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ZDR and non-ZDR share one Grok Responses path (store=false + encrypted reasoning). Drop the xAI store toggle and add multi-turn real-API coverage.
ammar-agent
changed the title
|
@codex review Follow-up:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1c865444d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed P1: extracted |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pixel review investigationLooked into the pending
Follow-up hardening (stories only, no product UI): #3810 |
2 participants
Summary
Make Grok 4.5 ZDR-safe by default (
store: falseon Responses) so ZDR and non-ZDR orgs share one code path and quality bar—without expanding settings surface. Keep encrypted reasoning round-trip so multi-turn tool use stays coherent without server storage.Background
xAI Grok 4.5 Responses defaults to
store: true. ZDR orgs reject that unlessstore: falseis sent. Mux already resends full history explicitly and can persist encrypted reasoning client-side, so server storage is unnecessary for quality.A separate xAI “Response storage” toggle would work but expands config surface and invites ZDR/non-ZDR quality divergence. Prefer one hard-coded path.
Implementation
store: falsefor Grok 4.5 inbuildProviderOptionsand factory request injection (explicit override still allowed for tests/escapes).itemId+reasoningEncryptedContent) is stored on reasoning parts for replay understore=false.Validation
make typecheck/make static-checkstore: false+include: reasoning.encrypted_contentTEST_INTEGRATION=1+XAI_API_KEY): multi-turn Grok test asserts encrypted reasoning in history after turn 1 and successful continuity on turn 2 understore: falseRisks
Generated with
mux• Model:xai:grok-4.5• Thinking:high• Cost:$8.62