🤖 tests: stabilize Storybook fixtures for Pixel flake reduction - #3810
🤖 tests: stabilize Storybook fixtures for Pixel flake reduction#3810ammar-agent wants to merge 2 commits into
Conversation
Replace nondeterministic Date.now/Math.random story fixtures with the shared NOW clock so baseline diffs are less likely across PR builds.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ba144b4ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the three P2s:
|
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Harden Storybook fixtures that used live
Date.now()/Math.random()so Pixel baselines are less flaky across PR builds. Opened separately from #3807 after investigating its pending Pixel review.Background
#3807 showed
Pixel / Review: 5 snapshots awaiting revieweven though its product UI change was limited to OpenAI store-toggle save behavior, andProvidersSectionstories are explicitlyPIXEL_DISABLED.Findings:
368 snapshots approved, auto-reviewed).Likely flake contributors found in story fixtures: relative timestamps / random module tokens that can still affect provider tree keys or labels when capture paths bypass the global
Date.nowstub or when modules are re-evaluated.Implementation
Replace nondeterministic time/random sources in Storybook stories with the shared
NOW/STABLE_TIMESTAMPfixtures (src/browser/stories/storyTime.ts):No production UI code changed.
Validation
make typecheckmake static-checkRisks
Generated with
mux• Model:xai:grok-4.5• Thinking:high