fix: remove load_plugin_textdomain (auto-loaded since WP 4.6) - #120
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoves the ChangesRemove textdomain init hook
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoRemove redundant load_plugin_textdomain (WordPress auto-loads since 4.6)
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Summary
load_plugin_textdomain()call fromslashed.phpentirely. Since WordPress 4.6, translations are loaded automatically for plugins hosted on WordPress.org using theText Domainplugin header — the explicit call is redundant.PluginCheck.CodeAnalysis.DiscouragedFunctions.load_plugin_textdomainFound) flagged on the previous release.Context
The previous PR (#119) moved the call from
plugins_loadedtoinitto resolve a WP 6.7_load_textdomain_just_in_timenotice. The Plugin Check tool then flagged the call as discouraged since WP 4.6. Removing it entirely is the correct long-term fix — no translation loading code is needed at all.Generated by Claude Code
Summary by CodeRabbit