fix: resolve WordPress Plugin Check errors and warnings - #48
Conversation
- Fix text domain mismatch in class-classes.php (slashed-bricks → slashed) - Remove deprecated load_plugin_textdomain() calls (auto-loaded since WP 4.6) - Add phpcs:ignore for manual CSS sanitization (wp_kses corrupts valid CSS selectors) - Add phpcs:ignore for direct DB query in reBEMer REST (caching incorrect for scan) - Add phpcs:ignore for dynamic hook names in class-inventory.php (prefixed via filter_slug())
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThree standalone-mode ChangesPHPCS Suppressions and Text Domain Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes all errors and warnings reported by the WordPress Plugin Check tool.
class-classes.php— strings usedslashed-bricksbut the unified plugin declaresslashedas its text domainload_plugin_textdomain()calls fromslashed.php,slashed-bricks.php, andslashed-gutenberg.php— deprecated since WP 4.6; WordPress.org auto-loads translations for hosted pluginsclass-manual-css-page.php—wp_kses()corrupts valid CSS selectors (e.g.>,[attr~="val"]); the value is validated against injection patterns and escaped at render timeclass-rebemer-rest.php— already uses$wpdb->prepare(); caching is incorrect here because the reBEMer scan result varies per callclass-inventory.php— hook names are correctly prefixed viafilter_slug()which returns the integration-specific prefix (e.g.slashed_bricks)Remaining non-issue
The
no_plugin_readmeerror is a false positive —readme.txtexists at the plugin root; Plugin Check ran from a subdirectory path.Test plan
languages/for WP.org-hosted plugins)Generated by Claude Code
Summary by cubic
Resolves all WordPress Plugin Check errors and warnings by fixing text domains, removing deprecated translation loaders, and silencing tool false positives without changing runtime behavior.
slashed-brickstoslashed.load_plugin_textdomain()fromslashed.php,integrations/bricks/slashed-bricks.php, andintegrations/gutenberg/slashed-gutenberg.php(WP auto-loads translations for WP.org plugins).phpcs:ignoreto avoid corrupting valid CSS; value is validated and escaped on output.phpcs:ignorefor direct DB query and no caching; queries are prepared and vary per call.phpcs:ignorefor dynamic hook names; names are safely prefixed viafilter_slug().Written for commit 49481cd. Summary will update on new commits.
Summary by CodeRabbit