docs: fix stale README content and make bundle-size badge self-updating - #280
Conversation
- Replace hardcoded '11.6kB' essential badge (actual 15.0kB) with a shields.io endpoint badge fed by dist/badge-essential.json, generated during build and published to the dist branch on every merge - Point release badge link to /releases (only prereleases exist, so /releases/latest 404s); pin CI badge to branch=main - Add core/tokens.color-fallbacks.css to the a la carte core list and optional/tokens.sizes-extended.css to the optional list - Show all 6 brand source tokens in the Customising tokens example (was 4) and clarify the 11 light + 11 dark token count - Correct test:install description (installs Chromium, Firefox & WebKit) Co-authored-by: Jack Granatowski <contact@codeslash.net>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates the build pipeline to generate a shields.io endpoint descriptor for the essential bundle gzip size at ChangesEssential bundle badge and documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request was created by @kiro-agent on behalf of @jackgranatowski 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Summary
The README contained several stale/untrue statements and a hardcoded, broken badge. This PR corrects the prose and makes the bundle-size badge update itself from the build pipeline.
Badges (now always current)
11.6kB gzipstatic badge linking todist/slashed.essential.min.css, which 404s onmain(dist is gitignored and lives only on thedistbranch). The actual size is 15.0 kB gzip. Replaced with a shields.ioendpointbadge fed bydist/badge-essential.json, now generated duringnpm run buildand published to thedistbranch bypublish-dist.ymlon every merge — so it self-updates and never goes stale. The badge now links to the real CDN file on jsDelivr./releases/latest, which 404s because every release so far is a prerelease (latest isv0.5.25). Repointed to/releases. The badge image already usedinclude_prereleases, so it was rendering fine.?branch=mainfor deterministic status.Prose accuracy
core/tokens.color-fallbacks.css(present in every bundle inbundle.config.json); added it afterlayers.css.optional/tokens.sizes-extended.css(part of theoptimalset); added it.-lighttokens (primary, secondary, tertiary, action, neutral, base), matchingdocs/theming.md, and clarifies the 11-light + 11-dark count (the 5 status colours auto-derive but are overridable).npm run test:installdescription said "Chromium test browser"; it actually installs Chromium, Firefox & WebKit (perpackage.json).New build output
scripts/bundle.jsnow writesdist/badge-essential.json(shields endpoint schema) computed from the freshly builtslashed.essential.min.cssgzip size.Testing
npm run build— succeeds; emitsdist/badge-essential.json→15.0 kB gzipnpm run lint:css— cleantier1-p*,api-index-sync) — 56/56 passNote
The endpoint badge resolves once this lands on
mainandpublish-dist.ymlregenerates thedistbranch withbadge-essential.json. Until then it will read as not-found on the branch preview — this self-heals on merge.Summary by CodeRabbit
Documentation
Chores