docs(landing): recommend <link> over @import for CDN install - #552
Conversation
PR Summary by Qododocs(landing): recommend over @import for CDN install
AI Description
Diagram
High-Level Assessment
Files changed (8)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
12 rules 1.
|
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThis PR reworks README.md's structure and content, removes copy-wip/github-readme.md and index.md content, drops a Jekyll exclude entry, updates docs/architecture.md to reflect partial component completion, updates index.html's token count and install snippets, and adds curated token overrides in demos/generate.mjs and demos/ultimate-override.css. ChangesDocumentation and site content overhaul
Demo curated token overrides
Estimated code review effort: 2 (Simple) | ~12 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@import at the top of a stylesheet is render-blocking and serialized: the browser must fetch and parse the parent sheet before discovering the import, then issue a second request that the preload scanner cannot see. Lead with <link rel="stylesheet"> as the recommended install and demote @import to a labelled alternative. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
…dance - Token count: 685 (copy-wip) / 840 (index.md) → 720 to match the generated source of truth (docs/tokens.md, token-index, api-index). - Component status: .sf-btn and .sf-card are LIVE since v0.7.0 — drop the stale 'commented out / inert until v0.8' claims; only the remaining components (badge, tag, alert, avatar, modal, skeleton, table) are staged. - Landing hero version pill: v0.6.19 → v0.7.0. - copy-wip landing install: lead with <link>, demote @import to a labelled alternative (render-blocking & serialized), matching index.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
Promote the copy-wip landing draft to the live site: it becomes the root index.html (layout: null, self-styled from the jsDelivr CDN) and replaces the old Jekyll-wrapped index.md. Content was already brought in sync with the framework in the previous commit (720 tokens, live component status, <link>-first install). Internal links verified against existing pages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
- architecture.md: .sf-btn and .sf-card are live since v0.7.0 — replace the stale 'every class commented out / no CSS emitted' claims (file map, layer notes, bundle table, feature-gating notes) with the partial-completion reality; only the remaining components stay staged. - demos: teach demos/generate.mjs the four new knob tokens (--sf-media-radius, --sf-color-selection-text--alt, and the two scroll-timeline exit-range knobs), then regenerate. The full-API demo now reports 720 tokens / 316 classes instead of the stale 711 / 308. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
Promote the copy-wip README draft to the repo root README.md: leaner structure, matches the new landing page's voice, and already carries the corrected facts (720 tokens, .sf-btn/.sf-card live since v0.7.0, <link>-first install). Port the Editor integration section (VS Code CSS Custom Data) forward so that shipped feature stays documented. With both copy-wip drafts now promoted (index.html + README.md), remove the empty copy-wip/ directory and its stale _config.yml exclude entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
Follow-up to the README swap: the previous commit staged the moved draft before the Editor-integration edit and the _config.yml cleanup landed. Add both now — the VS Code CSS Custom Data section is back in README, and _config.yml no longer excludes the removed copy-wip/ directory. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
The utility layer is not inert in 0.x: optional/utilities.css ships a curated subset — the heading (.sf-h1–.sf-h6), text-size (.sf-text-*), and hover-transform (.sf-hover-*) helpers are active (21 classes per the API index); the rest stay commented out. Correct the 'inert in 0.x' / 'empty stub' / 'no utility classes' wording in the README bundle table and intro, the landing bundle table, and architecture.md (file map, bundle table, layer notes) so the utilities and full bundles are described accurately. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
…nded Rebased onto main (#553), which finalized the component and utility surface: - Staged components (badge/tag/alert/avatar/modal/skeleton/table) were removed, not just commented out; .sf-btn and .sf-card are now the only two components SLASHED ships (BEM-first, no broad component library). Drop all 'remaining components staged/commented' wording in README, landing, and architecture.md, including the 'Deferred until components ship' framing. - The utilities layer activated more curated helpers (list-reset, marker, selection, sticky on top of heading/text-size/hover) — 31 active classes. Update the utility descriptions accordingly. - Regenerate demos against the rebased API index: 320 bundled classes (was 316); token count stays 720. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
78c37fd to
6377c09
Compare
Rebased fresh off main after #552 merged. Later PRs (#554–#559) grew the token set to 729 (new --sf-fluid-width and --sf-surface-bg-* knobs from #557) and renamed state classes to .sf-is-* (already reflected in the merged docs). Update the remaining stale counts: - README + landing: 720 → 729 design tokens. - architecture.md file-map: list the full active utility set (heading/text-size/hover/list-reset/marker/selection/sticky). - demos/generate.mjs: teach it the eight new --sf-surface-bg-* knobs (seven curated background overrides + skip the animation shorthand), then regenerate: 324 bundled classes / 729 tokens (was 320 / 720). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
@import at the top of a stylesheet is render-blocking and serialized:
the browser must fetch and parse the parent sheet before discovering the
import, then issue a second request that the preload scanner cannot see.
Lead with as the recommended install and demote
@import to a labelled alternative.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_016WH9Q15j1dZYxqTqMoomxq
Summary by CodeRabbit
Documentation
Chores