Pass active tab to tabs partial view#2098
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cellio
approved these changes
Jul 16, 2026
cellio
left a comment
Member
There was a problem hiding this comment.
LGTM. Ran through the tabs at both desktop and phone sizes.
ArtOfCode-
approved these changes
Jul 16, 2026
Oaphi
requested changes
Jul 18, 2026
Oaphi
self-requested a review
July 19, 2026 01:09
Oaphi
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change
This passes the name of the active tab to the partial view
app/views/users/_tabs.html.erbto remove the need for each tab to check the current page to decide if it should show as active.This is a fairly trivial change at this stage, but will become more useful in #2063 where a Moderator Tools tab will be introduced that needs to show as active for 11 different URLs.
Additional changes
This pull request also includes other changes triggered by working on the tabs:
Let me know if you'd prefer the Subscriptions page to be an independent page with no tabs along the top, or if you'd prefer to avoid any of these width reducing changes.