Fix SQL Server defaults when modifying columns - #320
Merged
Conversation
Collaborator
Author
|
Updated the implementation to address the dynamic-SQL injection concern:
Validation: Lucee suite 2,915 passed, 0 failed/errors, 3 skipped; formatting and |
elpete
marked this pull request as ready for review
August 12, 2026 18:45
elpete
added a commit
that referenced
this pull request
Aug 12, 2026
elpete
added a commit
that referenced
this pull request
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152
What changed
Root cause
The SQL Server modify-column compiler reused the create-column compiler, which placed
CONSTRAINT ... DEFAULTinline in anALTER COLUMNstatement. SQL Server does not accept default constraints in that position.Validation
box run-script format:checkgit diff --check