Skip to content

chore: update TrouBLE for subscription errors - #3

Open
colonelpanic8 wants to merge 1 commit into
mainfrom
deps/trouble-not-subscribed
Open

chore: update TrouBLE for subscription errors#3
colonelpanic8 wants to merge 1 commit into
mainfrom
deps/trouble-not-subscribed

Conversation

@colonelpanic8

@colonelpanic8 colonelpanic8 commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary

Why

TrouBLE previously returned Ok(()) when a connection had not subscribed to a characteristic. The updated revision returns Error::NotSubscribed, allowing RMK to distinguish a transmitted notification from one dropped before CCCD subscription.

All lockfile changes are mechanical replacements of the TrouBLE git source SHA.

Validation

  • RMK fetch-check passed with this exact Cargo.toml and lockfile update in the original combined CI run
  • every changed lockfile contains only the TrouBLE source revision replacement

Upstream change: embassy-rs/trouble#649

Stack continues with the BLE + dfu_split compile prerequisites in #4 and the focused readiness fix in #2.

@colonelpanic8 colonelpanic8 mentioned this pull request Jul 20, 2026
Open
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Size Report

Example main PR Diff .text .data .bss
use_config/nrf52832_ble 390.1 KiB 390.1 KiB +0.00% ⬆️ +36 0 0
use_config/nrf52840_ble 435.3 KiB 435.4 KiB +0.00% ⬆️ +36 0 0
use_config/nrf52840_ble_split (central) 489.0 KiB 489.0 KiB +0.00% ⬆️ +24 0 0
use_config/nrf52840_ble_split (peripheral) 315.9 KiB 315.9 KiB +0.00% ⬆️ +32 0 0
use_config/pi_pico_w_ble 663.3 KiB 663.4 KiB +0.01% ⬆️ +72 0 0
use_config/rp2040 145.6 KiB 145.6 KiB +0.00% 0 0 0
use_config/rp2040_split (central) 159.2 KiB 159.2 KiB +0.00% ⬇️ -4 0 0
use_config/rp2040_split (peripheral) 27.8 KiB 27.8 KiB +0.00% 0 0 0
use_config/stm32f1 61.8 KiB 61.8 KiB +0.00% 0 0 0
use_config/stm32h7 99.1 KiB 99.0 KiB +0.00% ⬇️ -4 0 0
use_rust/nrf52832_ble 377.3 KiB 377.3 KiB +0.01% ⬆️ +44 0 0
use_rust/nrf52840_ble 432.0 KiB 432.0 KiB +0.00% ⬆️ +32 0 0
use_rust/nrf52840_ble_split (central) 497.4 KiB 497.5 KiB +0.00% ⬆️ +36 0 0
use_rust/nrf52840_ble_split (peripheral) 312.1 KiB 312.1 KiB +0.01% ⬆️ +32 0 0
use_rust/pi_pico_w_ble 663.6 KiB 663.7 KiB +0.01% ⬆️ +72 0 0
use_rust/rp2040 145.1 KiB 145.1 KiB +0.00% 0 0 0
use_rust/rp2040_split (central) 158.0 KiB 158.0 KiB +0.00% ⬇️ -4 0 0
use_rust/rp2040_split (peripheral) 28.2 KiB 28.2 KiB +0.00% 0 0 0
use_rust/stm32f1 61.3 KiB 61.3 KiB +0.00% 0 0 0
use_rust/stm32h7 119.6 KiB 119.6 KiB +0.00% ⬇️ -4 0 0
use_config/nrf52832_ble — 390.1 KiB → 390.1 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 361460	   4588	  33456	 399504	  61890	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 361424	   4588	  33456	 399468	  6186c	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +493  [ = ]       0    .debug_info
  +0.0%    +188  [ = ]       0    .debug_loc
  +0.0%    +150  [ = ]       0    .debug_str
  +0.0%     +24  +0.0%     +24    .text
  +0.0%     +15  [ = ]       0    .debug_line
  +0.0%     +12  +0.0%     +12    .rodata
  -0.0%      -6  [ = ]       0    .strtab
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.0%      -8  [ = ]       0    .debug_ranges
 -15.1%      -8  [ = ]       0    [Unmapped]
  -0.0%     -16  [ = ]       0    .debug_frame
  -0.0%     -32  [ = ]       0    .symtab
  +0.0%    +804  +0.0%     +36    TOTAL
use_config/nrf52840_ble — 435.3 KiB → 435.4 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 394200	   4596	  47016	 445812	  6cd74	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 394164	   4596	  47016	 445776	  6cd50	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +521  [ = ]       0    .debug_info
  +0.0%    +188  [ = ]       0    .debug_loc
  +0.0%    +150  [ = ]       0    .debug_str
  +0.0%     +44  [ = ]       0    .debug_line
   +78%     +31  [ = ]       0    [Unmapped]
  +0.0%     +24  +0.0%     +24    .text
  +0.0%     +12  +0.0%     +12    .rodata
  -0.0%      -6  [ = ]       0    .strtab
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.0%      -8  [ = ]       0    .debug_ranges
  -0.0%     -16  [ = ]       0    .debug_frame
  -0.0%     -32  [ = ]       0    .symtab
  +0.0%    +900  +0.0%     +36    TOTAL
use_config/nrf52840_ble_split (central) — 489.0 KiB → 489.0 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 450544	   4652	  45536	 500732	  7a3fc	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 450520	   4652	  45536	 500708	  7a3e4	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +625  [ = ]       0    .debug_info
  +0.0%    +258  [ = ]       0    .debug_str
  +0.0%     +61  [ = ]       0    .debug_line
  +0.0%     +61  [ = ]       0    .debug_loc
  +0.0%     +12  +0.0%     +12    .rodata
  +0.0%     +12  +0.0%     +12    .text
   +12%      +5  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .strtab
  +0.0%   +1024  +0.0%     +24    TOTAL
use_config/nrf52840_ble_split (peripheral) — 315.9 KiB → 315.9 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 291868	   4468	  27184	 323520	  4efc0	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 291836	   4468	  27184	 323488	  4efa0	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +253  [ = ]       0    .debug_info
  +0.0%    +130  [ = ]       0    .debug_str
  +0.0%     +47  [ = ]       0    .debug_loc
  +0.0%     +20  +0.0%     +20    .text
  +0.0%     +12  +0.0%     +12    .rodata
  -8.8%      -6  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_line
  -0.0%     -10  [ = ]       0    .strtab
  +0.0%    +436  +0.0%     +32    TOTAL
use_config/pi_pico_w_ble — 663.3 KiB → 663.4 KiB (+0.01% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 626032	      0	  53308	 679340	  a5dac	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 625960	      0	  53308	 679268	  a5d64	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +479  [ = ]       0    .debug_info
  +0.0%    +129  [ = ]       0    .debug_line
  +0.0%     +60  +0.0%     +60    .text
  +0.0%     +44  [ = ]       0    .strtab
  +0.0%     +32  [ = ]       0    .symtab
   +55%     +23  [ = ]       0    [Unmapped]
  +0.0%     +12  +0.0%     +12    .rodata
  -0.0%      -4  [ = ]       0    .debug_str
  -0.0%     -56  [ = ]       0    .debug_ranges
  -0.1%    -703  [ = ]       0    .debug_loc
  +0.0%     +16  +0.0%     +72    TOTAL
use_config/rp2040 — 145.6 KiB → 145.6 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 134412	      0	  14724	 149136	  24690	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 134412	      0	  14724	 149136	  24690	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +101  [ = ]       0    .debug_str
  +0.1%     +92  [ = ]       0    .debug_line
  +0.0%     +37  [ = ]       0    .debug_info
  +0.0%      +1  [ = ]       0    .strtab
  -2.6%      -1  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .debug_loc
  +0.0%    +228  [ = ]       0    TOTAL
use_config/rp2040_split (central) — 159.2 KiB → 159.2 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 147472	      0	  15588	 163060	  27cf4	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 147476	      0	  15588	 163064	  27cf8	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +1.96Ki  [ = ]       0    .debug_str
  +0.2%    +265  [ = ]       0    .strtab
  +0.0%     +12  [ = ]       0    .debug_loc
  +4.8%      +3  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  +0.1% +2.23Ki  -0.0%      -4    TOTAL
use_config/rp2040_split (peripheral) — 27.8 KiB → 27.8 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  25616	     60	   2796	  28472	   6f38	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  25616	     60	   2796	  28472	   6f38	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +589  [ = ]       0    .debug_str
  +0.1%     +31  [ = ]       0    .strtab
  +0.0%    +620  [ = ]       0    TOTAL
use_config/stm32f1 — 61.8 KiB → 61.8 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  56540	     28	   6740	  63308	   f74c	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  56540	     28	   6740	  63308	   f74c	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +1  [ = ]       0    .debug_str
  -1.8%      -1  [ = ]       0    [Unmapped]
  [ = ]       0  [ = ]       0    TOTAL
use_config/stm32h7 — 99.1 KiB → 99.0 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  92232	    264	   8928	 101424	  18c30	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  92236	    264	   8928	 101428	  18c34	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2%    +266  [ = ]       0    .debug_line
  +0.0%     +36  [ = ]       0    .debug_info
   +12%      +7  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  -0.3%    -195  [ = ]       0    .strtab
  -0.1% -1.26Ki  [ = ]       0    .debug_str
  -0.0% -1.15Ki  -0.0%      -4    TOTAL
use_rust/nrf52832_ble — 377.3 KiB → 377.3 KiB (+0.01% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 349312	   4588	  32488	 386388	  5e554	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 349268	   4588	  32488	 386344	  5e528	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +2.28Ki  [ = ]       0    .debug_str
  +0.0%    +413  [ = ]       0    .debug_info
  +0.1%    +264  [ = ]       0    .strtab
  +0.0%     +32  +0.0%     +32    .text
  +0.0%     +30  [ = ]       0    .debug_loc
   +42%     +20  [ = ]       0    [Unmapped]
  +0.0%     +12  +0.0%     +12    .rodata
  -0.2%     -16  [ = ]       0    .debug_abbrev
  -0.0%     -93  [ = ]       0    .debug_line
  +0.0% +2.93Ki  +0.0%     +44    TOTAL
use_rust/nrf52840_ble — 432.0 KiB → 432.0 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 394432	   4588	  43352	 442372	  6c004	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 394400	   4588	  43352	 442340	  6bfe4	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +729  [ = ]       0    .debug_info
  +0.0%    +269  [ = ]       0    .debug_str
  +0.1%    +223  [ = ]       0    .debug_line
  +0.0%    +178  [ = ]       0    .debug_loc
  +0.5%     +39  [ = ]       0    .debug_abbrev
  +0.0%     +20  +0.0%     +20    .text
  +0.0%     +19  [ = ]       0    .strtab
  +0.0%     +12  +0.0%     +12    .rodata
  -6.9%      -5  [ = ]       0    [Unmapped]
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.0%      -8  [ = ]       0    .debug_ranges
  -0.0%     -16  [ = ]       0    .debug_frame
  -0.0%     -32  [ = ]       0    .symtab
  +0.0% +1.39Ki  +0.0%     +32    TOTAL
use_rust/nrf52840_ble_split (central) — 497.4 KiB → 497.5 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 454288	   4652	  50464	 509404	  7c5dc	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 454252	   4652	  50464	 509368	  7c5b8	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +352  [ = ]       0    .debug_info
  +0.0%    +144  [ = ]       0    .debug_str
  +0.0%     +61  [ = ]       0    .debug_loc
  +0.0%     +26  [ = ]       0    .strtab
  +0.0%     +24  +0.0%     +24    .text
  +0.0%     +12  +0.0%     +12    .rodata
 -10.3%      -6  [ = ]       0    [Unmapped]
  -0.5%     -39  [ = ]       0    .debug_abbrev
  -0.1%    -190  [ = ]       0    .debug_line
  +0.0%    +384  +0.0%     +36    TOTAL
use_rust/nrf52840_ble_split (peripheral) — 312.1 KiB → 312.1 KiB (+0.01% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 289696	   4468	  25432	 319596	  4e06c	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 289664	   4468	  25432	 319564	  4e04c	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +253  [ = ]       0    .debug_info
  +0.0%    +130  [ = ]       0    .debug_str
  +0.0%     +47  [ = ]       0    .debug_loc
  +0.0%     +20  +0.0%     +20    .text
  +0.0%     +12  +0.0%     +12    .rodata
  -3.3%      -2  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_line
  -0.0%     -10  [ = ]       0    .strtab
  +0.0%    +440  +0.0%     +32    TOTAL
use_rust/pi_pico_w_ble — 663.6 KiB → 663.7 KiB (+0.01% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 626120	      0	  53500	 679620	  a5ec4	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 626048	      0	  53500	 679548	  a5e7c	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +484  [ = ]       0    .debug_info
  +0.0%    +122  [ = ]       0    .debug_line
  +0.0%     +60  +0.0%     +60    .text
  +0.0%     +32  [ = ]       0    .symtab
   +56%     +27  [ = ]       0    [Unmapped]
  +0.0%     +22  [ = ]       0    .strtab
  +0.0%     +12  +0.0%     +12    .rodata
  -0.0%     -48  [ = ]       0    .debug_str
  -0.0%     -56  [ = ]       0    .debug_ranges
  -0.1%    -703  [ = ]       0    .debug_loc
  -0.0%     -48  +0.0%     +72    TOTAL
use_rust/rp2040 — 145.1 KiB → 145.1 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 133988	      0	  14644	 148632	  24498	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 133988	      0	  14644	 148632	  24498	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +2.01Ki  [ = ]       0    .debug_str
  +0.2%    +211  [ = ]       0    .strtab
  +4.5%      +2  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_loc
  +0.1% +2.21Ki  [ = ]       0    TOTAL
use_rust/rp2040_split (central) — 158.0 KiB → 158.0 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 146356	      0	  15420	 161776	  277f0	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 146360	      0	  15420	 161780	  277f4	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +5.5%      +3  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  -0.0%      -6  [ = ]       0    .strtab
  -0.0%     -10  [ = ]       0    .debug_loc
  -0.0%     -37  [ = ]       0    .debug_info
  -0.0%    -106  [ = ]       0    .debug_str
  -0.1%    -124  [ = ]       0    .debug_line
  -0.0%    -284  -0.0%      -4    TOTAL
use_rust/rp2040_split (peripheral) — 28.2 KiB → 28.2 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  25716	     60	   3060	  28836	   70a4	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  25716	     60	   3060	  28836	   70a4	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL
use_rust/stm32f1 — 61.3 KiB → 61.3 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  55940	     28	   6756	  62724	   f504	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  55940	     28	   6756	  62724	   f504	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +982  [ = ]       0    .debug_str
  +0.2%    +107  [ = ]       0    .strtab
  -2.0%      -1  [ = ]       0    [Unmapped]
  +0.1% +1.06Ki  [ = ]       0    TOTAL
use_rust/stm32h7 — 119.6 KiB → 119.6 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 107236	    320	  14924	 122480	  1de70	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 107240	    320	  14924	 122484	  1de74	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +124  [ = ]       0    .debug_line
  +0.0%     +37  [ = ]       0    .debug_info
   +12%      +5  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  -0.2%    -181  [ = ]       0    .strtab
  -0.1% -1.97Ki  [ = ]       0    .debug_str
  -0.0% -1.99Ki  -0.0%      -4    TOTAL

@colonelpanic8 colonelpanic8 mentioned this pull request Jul 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@colonelpanic8